Auto merge of #1753 - integer32llc:fix-yank-test, r=jtgeibel

Fix yank test

This test wasn't set up correctly, so the error message that was being checked wasn't quite right.

Also, [based on this comment](#1697 (comment)) it seems like the names of these tests weren't as descriptive as they could be-- the previous test covers the success case of an owner being able to yank, and the next text checks that nonowners aren't allowed to yank.

Author: bors

src/tests/http-data/krate_yank renamed to src/tests/http-data/krate_yank_works_as_intended

@@ -1386,7 +1386,7 @@ fn following() {
 }
 
 #[test]
-fn yank() {
+fn yank_works_as_intended() {
     let (app, anon, _, token) = TestApp::full().with_token();
 
     // Upload a new crate, putting it in the git index
@@ -1424,19 +1424,21 @@ fn yank() {
 }
 
 #[test]
-fn yank_not_owner() {
+fn yank_by_a_non_owner_fails() {
     let (app, _, _, token) = TestApp::full().with_token();
 
     let another_user = app.db_new_user("bar");
     let another_user = another_user.as_model();
     app.db(|conn| {
-        CrateBuilder::new("foo_not", another_user.id).expect_build(conn);
+        CrateBuilder::new("foo_not", another_user.id)
+            .version("1.0.0")
+            .expect_build(conn);
     });
 
     let json = token.yank("foo_not", "1.0.0").bad_with_status(200);
     assert_eq!(
         json.errors[0].detail,
-        "crate `foo_not` does not have a version `1.0.0`"
+        "must already be an owner to yank or unyank"
     );
 }