cleanup + some es6ification

Author: stefanpenner

app/adapters/dependency.js

@@ -1,9 +1,9 @@
 import ApplicationAdapter from './application';
 
 export default ApplicationAdapter.extend({
-    findQuery: function(store, type, query) {
+    findQuery(store, type, query) {
         if (!query.reverse) {
-            return this._super(store, type, query);
+            return this._super(...arguments);
         }
         delete query.reverse;
         var crate = query.crate;

app/app.js

@@ -12,6 +12,8 @@ var App = Ember.Application.extend({
 });
 
 loadInitializers(App, config.modulePrefix);
-Ember.$.ajaxSetup({cache: false});
+Ember.$.ajaxSetup({
+  cache: false
+});
 
 export default App;

app/components/user-avatar.js

@@ -1,26 +1,26 @@
 import Ember from 'ember';
 
+const { computed } = Ember;
+
 export default Ember.Component.extend({
     size: 'small',
     user: null,
     attributeBindings: ['src', 'width', 'height'],
     tagName: 'img',
 
-    width: function() {
+    width: computed('size', function() {
         if (this.get('size') === 'small') {
             return 22;
         } else if (this.get('size') === 'medium-small') {
             return 32;
         } else {
             return 85; // medium
         }
-    }.property('size'),
+    }),
 
-    height: function() {
-        return this.get('width');
-    }.property('width'),
+    height: computed.readOnly('width'),
 
-    src: function() {
+    src: computed('size', 'user', function() {
         return this.get('user.avatar') + '&s=' + this.get('width');
-    }.property('size', 'user'),
+    })
 });

app/components/user-link.js

@@ -1,17 +1,16 @@
 import Ember from 'ember';
 
+const { computed } = Ember;
+
 export default Ember.Component.extend({
   user: null,
   attributeBindings: ['title', 'href'],
   tagName: 'a',
 
-  title: function() {
-      return this.get('user.login');
-  }.property('user'),
-
-  'href': function() {
+  title: computed.readOnly('user.login'),
+  href: computed('user', function() {
       // TODO replace this with a link to a native crates.io profile
       // page when they exist.
-      return 'https://github.com/' + this.get('user.login');
-  }.property('user'),
+      return `https://github.com/${this.get('user.login')}`;
+  })
 });

app/controllers/application.js

@@ -1,5 +1,7 @@
 import Ember from 'ember';
 
+const { observer } = Ember;
+
 export default Ember.Controller.extend({
     needs: ['search'],
 
@@ -8,44 +10,53 @@ export default Ember.Controller.extend({
     showUserOptions: false,
     search: Ember.computed.oneWay('controllers.search.q'),
 
-    stepFlash: function() {
+    stepFlash() {
         this.set('flashError', this.get('nextFlashError'));
         this.set('nextFlashError', null);
     },
 
-    aboutToTransition: function() {
+    aboutToTransition() {
         Ember.$(document).trigger('mousedown');
     },
 
-    resetDropdownOption: function(controller, option) {
-        controller.set(option, !controller.get(option));
-        if (controller.get(option)) {
-            Ember.$(document).on('mousedown.useroptions', function(e) {
+    // don't use this from other controllers..
+    resetDropdownOption(controller, option) {
+        this.set(option, !this.get(option));
+        if (this.get(option)) {
+            Ember.$(document).on('mousedown.useroptions', (e) => {
                 if (Ember.$(e.target).prop('tagName') === 'INPUT') {
                     return;
                 }
-                Ember.run.later(function() {
-                    controller.set(option, false);
+                Ember.run.later(() => {
+                    this.set(option, false);
                 }, 150);
                 Ember.$(document).off('mousedown.useroptions');
             });
         }
     },
 
-    currentPathChanged: function () {
+    _scrollToTop() {
         window.scrollTo(0, 0);
-    }.observes('currentPath'),
+    },
+
+    // TODO: remove observer & DOM mutation in controller..
+    currentPathChanged: observer('currentPath', function () {
+      Ember.run.scheduleOnce('afterRender', this, this._scrollToTop);
+    }),
 
     actions: {
-        search: function(query) {
+        search(q) {
             this.transitionToRoute('search', {
-              queryParams: {q: query, page: 1}
+              queryParams: {
+                q,
+                page: 1
+              }
             });
         },
 
-        toggleUserOptions: function() {
+        toggleUserOptions() {
             this.resetDropdownOption(this, 'showUserOptions');
-        },
-    },
+        }
+    }
 });
 

app/controllers/catch-all.js

@@ -2,7 +2,7 @@ import Ember from 'ember';
 
 export default Ember.Controller.extend({
     actions: {
-        search: function(query) {
+        search(query) {
             return this.transitionToRoute('search', {queryParams: {q: query}});
         },
     },