crate.version: Redirect to unspecific version URL if requested version does not exist

Author: Turbo87

app/routes/crate/version.js

@@ -52,6 +52,8 @@ export default class VersionRoute extends Route {
     const version = versions.find(version => version.num === params.version_num);
     if (params.version_num && !version) {
       this.notifications.error(`Version '${params.version_num}' of crate '${crate.name}' does not exist`);
+      this.replaceWith('crate.index');
+      return;
     }
 
     return {

tests/acceptance/crate-test.js

@@ -88,7 +88,7 @@ module('Acceptance | crate page', function (hooks) {
 
     await visit('/crates/nanomsg/0.7.0');
 
-    assert.equal(currentURL(), '/crates/nanomsg/0.7.0');
+    assert.equal(currentURL(), '/crates/nanomsg');
     assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
     assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.1');
     assert.dom('[data-test-notification-message]').hasText("Version '0.7.0' of crate 'nanomsg' does not exist");

tests/routes/crate/version/model-test.js

@@ -22,17 +22,16 @@ module('Route | crate.version | model() hook', function (hooks) {
       assert.dom('[data-test-notification-message]').doesNotExist();
     });
 
-    test('defaults to `max_version` if requested version can not be found', async function (assert) {
+    test('redirects to unspecific version URL', async function (assert) {
       let crate = this.server.create('crate', { name: 'foo' });
       this.server.create('version', { crate, num: '1.0.0' });
       this.server.create('version', { crate, num: '1.2.3', yanked: true });
       this.server.create('version', { crate, num: '2.0.0-beta.1' });
 
       await visit('/crates/foo/2.0.0');
-      // TODO this should probably redirect to `/crates/foo` instead
-      assert.equal(currentURL(), `/crates/foo/2.0.0`);
+      assert.equal(currentURL(), `/crates/foo`);
       assert.dom('[data-test-crate-name]').hasText('foo');
-      assert.dom('[data-test-crate-version]').hasText('2.0.0-beta.1');
+      assert.dom('[data-test-crate-version]').hasText('1.0.0');
       assert.dom('[data-test-notification-message="error"]').hasText("Version '2.0.0' of crate 'foo' does not exist");
     });
   });