Auto merge of #3043 - Turbo87:plural, r=locks

Fix broken pluralizations

Passing the formatted number into the `pluralize` helper doesn't work quite as expected, and in these cases we already know the pluralization, so using the `pluralize` helper is somewhat pointless anyway.

Resolves #3042

r? `@jtgeibel`

Author: bors

app/templates/categories.hbs

@@ -27,7 +27,7 @@
           {{category.category}}
         </LinkTo>
         <span local-class="crate-count" data-test-crate-count>
-          {{ pluralize (format-num category.crates_cnt) "crate" }}
+          {{format-num category.crates_cnt}} {{if (eq category.crates_cnt 1) "crate" "crates"}}
         </span>
       </div>
       <div local-class="description">

app/templates/category/index.hbs

@@ -21,7 +21,7 @@
           <div>
             <LinkTo @route="category" @model={{subcategory.slug}}>{{subcategory.category}}</LinkTo>
             <span local-class="crate-count">
-              {{ pluralize (format-num subcategory.crates_cnt) "crate" }}
+              {{format-num subcategory.crates_cnt}} {{if (eq subcategory.crates_cnt 1) "crate" "crates"}}
             </span>
           </div>
           <div local-class="category-description">

app/templates/keywords.hbs

@@ -24,7 +24,7 @@
     <div local-class="row">
       <LinkTo @route="keyword" @model={{keyword}}>{{keyword.id}}</LinkTo>
       <span local-class="crate-count">
-        {{ pluralize (format-num keyword.crates_cnt) "crate" }}
+        {{format-num keyword.crates_cnt}} {{if (eq keyword.crates_cnt 1) "crate" "crates"}}
       </span>
     </div>
   {{/each}}

mirage/serializers/category.js

@@ -19,6 +19,6 @@ export default BaseSerializer.extend({
     let allCrates = this.schema.crates.all();
     let associatedCrates = allCrates.filter(it => it.categoryIds.includes(hash.id));
 
-    hash.crates_cnt = associatedCrates.length;
+    hash.crates_cnt ??= associatedCrates.length;
   },
 });

mirage/serializers/keyword.js

@@ -19,6 +19,6 @@ export default BaseSerializer.extend({
     let allCrates = this.schema.crates.all();
     let associatedCrates = allCrates.filter(it => it.keywordIds.includes(hash.id));
 
-    hash.crates_cnt = associatedCrates.length;
+    hash.crates_cnt ??= associatedCrates.length;
   },
 });

tests/acceptance/categories-test.js

@@ -4,31 +4,47 @@ import { module, test } from 'qunit';
 
 import percySnapshot from '@percy/ember';
 import a11yAudit from 'ember-a11y-testing/test-support/audit';
+import window from 'ember-window-mock';
+import { setupWindowMock } from 'ember-window-mock/test-support';
 
 import axeConfig from '../axe-config';
 import setupMirage from '../helpers/setup-mirage';
 
 module('Acceptance | categories', function (hooks) {
   setupApplicationTest(hooks);
+  setupWindowMock(hooks);
   setupMirage(hooks);
 
   test('listing categories', async function (assert) {
+    window.navigator = { languages: ['en'] };
+
     this.server.create('category', { category: 'API bindings' });
     this.server.create('category', { category: 'Algorithms' });
     this.server.createList('crate', 1, { categoryIds: ['algorithms'] });
     this.server.create('category', { category: 'Asynchronous' });
     this.server.createList('crate', 15, { categoryIds: ['asynchronous'] });
+    this.server.create('category', { category: 'Everything', crates_cnt: 1234 });
 
     await visit('/categories');
 
     assert.dom('[data-test-category="api-bindings"] [data-test-crate-count]').hasText('0 crates');
     assert.dom('[data-test-category="algorithms"] [data-test-crate-count]').hasText('1 crate');
     assert.dom('[data-test-category="asynchronous"] [data-test-crate-count]').hasText('15 crates');
+    assert.dom('[data-test-category="everything"] [data-test-crate-count]').hasText('1,234 crates');
 
     await percySnapshot(assert);
     await a11yAudit(axeConfig);
   });
 
+  test('listing categories (locale: de)', async function (assert) {
+    window.navigator = { languages: ['de'] };
+
+    this.server.create('category', { category: 'Everything', crates_cnt: 1234 });
+
+    await visit('/categories');
+    assert.dom('[data-test-category="everything"] [data-test-crate-count]').hasText('1.234 crates');
+  });
+
   test('category/:category_id index default sort is recent-downloads', async function (assert) {
     this.server.create('category', { category: 'Algorithms' });