mirage/crate: Replace versions property with relationship

Author: Turbo87

mirage/factories/crate.js

@@ -23,7 +23,6 @@ export default Factory.extend({
   updated_at: '2017-02-24T12:34:56Z',
 
   badges: () => [],
-  versions: () => [],
   _extra_downloads: () => [],
   _owner_teams: () => [],
   _owner_users: () => [],

mirage/factories/version.js

@@ -18,12 +18,9 @@ export default Factory.extend({
 
   crate_size: i => (((i + 13) * 42) % 13) * 54321,
 
-  afterCreate(version, server) {
+  afterCreate(version) {
     if (!version.crateId) {
       throw new Error(`Missing \`crate\` relationship on \`version:${version.num}\``);
     }
-
-    let crate = server.schema.crates.find(version.crateId);
-    crate.update({ versions: crate.versions.concat(parseInt(version.id, 10)) });
   },
 });

mirage/models/crate.js

@@ -3,4 +3,5 @@ import { Model, hasMany } from 'ember-cli-mirage';
 export default Model.extend({
   categories: hasMany(),
   keywords: hasMany(),
+  versions: hasMany(),
 });

mirage/route-handlers/crates.js

@@ -38,15 +38,11 @@ export function register(server) {
     let crate = schema.crates.find(crateId);
     if (!crate) return notFound();
 
-    let versions = schema.versions
-      .all()
-      .filter(version => (crate.versions || []).indexOf(parseInt(version.id, 10)) !== -1);
-
     return {
       ...this.serialize(crate),
       ...this.serialize(crate.categories),
       ...this.serialize(crate.keywords),
-      ...this.serialize(versions),
+      ...this.serialize(crate.versions),
     };
   });
 
@@ -59,7 +55,7 @@ export function register(server) {
     let crate = schema.crates.find(crateId);
     if (!crate) return notFound();
 
-    return schema.versions.where({ crateId }).sort((a, b) => compareIsoDates(b.created_at, a.created_at));
+    return crate.versions.sort((a, b) => compareIsoDates(b.created_at, a.created_at));
   });
 
   server.get('/api/v1/crates/:crate_id/:version_num/authors', (schema, request) => {
@@ -155,9 +151,7 @@ export function register(server) {
     let crate = schema.crates.find(crateId);
     if (!crate) return notFound();
 
-    let versionDownloads = schema.versionDownloads
-      .all()
-      .filter(it => crate.versions.indexOf(parseInt(it.versionId, 10)) !== -1);
+    let versionDownloads = schema.versionDownloads.all().filter(it => it.version.crateId === crateId);
 
     return withMeta(this.serialize(versionDownloads), { extra_downloads: crate._extra_downloads });
   });

mirage/serializers/crate.js

@@ -51,5 +51,8 @@ export default BaseSerializer.extend({
 
     hash.keywords = hash.keyword_ids;
     delete hash.keyword_ids;
+
+    hash.versions = hash.version_ids;
+    delete hash.version_ids;
   },
 });

tests/mirage/crates-test.js

@@ -224,6 +224,7 @@ module('Mirage | Keywords', function(hooks) {
       assert.equal(response.status, 200);
 
       let responsePayload = await response.json();
+      assert.deepEqual(responsePayload.crate.versions, ['1', '2', '3']);
       assert.deepEqual(responsePayload.versions, [
         {
           id: '1',