Skip to content

Commit 7eedf1b

Browse files
committed
Give tests better failure messages
I'd rather start debugging from the diff of the expected vs actual text, rather than "expected true got false".
1 parent 8ea53f3 commit 7eedf1b

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

src/render.rs

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,8 @@ mod tests {
123123
#[test]
124124
fn empty_text() {
125125
let text = "";
126-
let result = markdown_to_html(text);
127-
assert_eq!(result.is_ok(), true);
128-
let rendered = result.unwrap();
129-
assert_eq!(rendered, "");
126+
let result = markdown_to_html(text).unwrap();
127+
assert_eq!(result, "");
130128
}
131129

132130
#[test]
@@ -150,27 +148,19 @@ mod tests {
150148
}
151149

152150
#[test]
153-
fn text_with_unknwon_tag() {
151+
fn text_with_unknown_tag() {
154152
let text = "foo_readme\n\n<unknown>alert('Hello World')</unknown>";
155-
let result = markdown_to_html(text);
156-
assert_eq!(result.is_ok(), true);
157-
let rendered = result.unwrap();
158-
assert_eq!(rendered.contains("foo_readme"), true);
159-
assert_eq!(rendered.contains("unknown"), false);
160-
assert_eq!(rendered.contains("alert('Hello World')"), true);
153+
let result = markdown_to_html(text).unwrap();
154+
assert_eq!(result, "<p>foo_readme</p>\n<p>alert(\'Hello World\')</p>\n");
161155
}
162156

163157
#[test]
164158
fn text_with_inline_javascript() {
165159
let text = r#"foo_readme\n\n<a href="https://crates.io/crates/cargo-registry" onclick="window.alert('Got you')">Crate page</a>"#;
166-
let result = markdown_to_html(text);
167-
assert_eq!(result.is_ok(), true);
168-
let rendered = result.unwrap();
169-
assert_eq!(rendered.contains("foo_readme"), true);
170-
assert_eq!(rendered.contains("<a"), true);
171-
assert_eq!(rendered.contains("href="), true);
172-
assert_eq!(rendered.contains("onclick"), false);
173-
assert_eq!(rendered.contains("window.alert"), false);
174-
assert_eq!(rendered.contains("Crate page"), true);
160+
let result = markdown_to_html(text).unwrap();
161+
assert_eq!(
162+
result,
163+
"<p>foo_readme\\n\\n<a href=\"https://crates.io/crates/cargo-registry\">Crate page</a></p>\n"
164+
);
175165
}
176166
}

0 commit comments

Comments
 (0)