Skip to content

Commit 28c1bbd

Browse files
committed
cargo fmt
1 parent 305116a commit 28c1bbd

File tree

3 files changed

+53
-22
lines changed

3 files changed

+53
-22
lines changed

src/krate.rs

Lines changed: 40 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ use {Model, User, Keyword, Version, Category, Badge, Replica};
4343
#[derive(Insertable, Queryable, Identifiable, Associations, AsChangeset)]
4444
#[belongs_to(Crate)]
4545
#[primary_key(crate_id, date)]
46-
#[table_name="crate_downloads"]
46+
#[table_name = "crate_downloads"]
4747
pub struct CrateDownload {
4848
pub crate_id: i32,
4949
pub downloads: i32,
@@ -498,7 +498,15 @@ impl Crate {
498498
exact_match: bool,
499499
recent_downloads: Option<i64>,
500500
) -> EncodableCrate {
501-
self.encodable(max_version, None, None, None, badges, exact_match, recent_downloads)
501+
self.encodable(
502+
max_version,
503+
None,
504+
None,
505+
None,
506+
badges,
507+
exact_match,
508+
recent_downloads,
509+
)
502510
}
503511

504512
pub fn encodable(
@@ -752,20 +760,26 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
752760
let conn = req.db_conn()?;
753761
let (offset, limit) = req.pagination(10, 100)?;
754762
let params = req.query();
755-
let sort = params.get("sort").map(|s| &**s).unwrap_or("recent-downloads");
763+
let sort = params.get("sort").map(|s| &**s).unwrap_or(
764+
"recent-downloads",
765+
);
756766

757767
let recent_downloads = sql::<Nullable<BigInt>>("SUM(crate_downloads.downloads)");
758768

759769
let mut query = crates::table
760770
.join(
761771
crate_downloads::table,
762772
LeftOuter,
763-
crates::id
764-
.eq(crate_downloads::crate_id)
765-
.and(crate_downloads::date.gt(date(now - 90.days())))
766-
)
773+
crates::id.eq(crate_downloads::crate_id).and(
774+
crate_downloads::date.gt(date(now - 90.days())),
775+
),
776+
)
767777
.group_by(crates::id)
768-
.select((ALL_COLUMNS, AsExpression::<Bool>::as_expression(false), recent_downloads.clone()))
778+
.select((
779+
ALL_COLUMNS,
780+
AsExpression::<Bool>::as_expression(false),
781+
recent_downloads.clone(),
782+
))
769783
.into_boxed();
770784

771785
if sort == "downloads" {
@@ -785,7 +799,11 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
785799
),
786800
));
787801

788-
query = query.select((ALL_COLUMNS, crates::name.eq(q_string), recent_downloads.clone()));
802+
query = query.select((
803+
ALL_COLUMNS,
804+
crates::name.eq(q_string),
805+
recent_downloads.clone(),
806+
));
789807
let perfect_match = crates::name.eq(q_string).desc();
790808
if sort == "downloads" {
791809
query = query.order((perfect_match, crates::downloads.desc()));
@@ -857,15 +875,21 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
857875
));
858876
}
859877

860-
let data = query.paginate(limit, offset).load::<((Crate, bool, Option<i64>), i64)>(
861-
&*conn,
862-
)?;
878+
let data = query
879+
.paginate(limit, offset)
880+
.load::<((Crate, bool, Option<i64>), i64)>(&*conn)?;
863881
let total = data.first().map(|&(_, t)| t).unwrap_or(0);
864882
let crates = data.iter()
865883
.map(|&((ref c, _, _), _)| c.clone())
866884
.collect::<Vec<_>>();
867-
let perfect_matches = data.clone().into_iter().map(|((_, b, _), _)| b).collect::<Vec<_>>();
868-
let recent_downloads = data.clone().into_iter().map(|((_, _, s), _)| s.unwrap_or(0)).collect::<Vec<_>>();
885+
let perfect_matches = data.clone()
886+
.into_iter()
887+
.map(|((_, b, _), _)| b)
888+
.collect::<Vec<_>>();
889+
let recent_downloads = data.clone()
890+
.into_iter()
891+
.map(|((_, _, s), _)| s.unwrap_or(0))
892+
.collect::<Vec<_>>();
869893

870894
let versions = Version::belonging_to(&crates)
871895
.load::<Version>(&*conn)?
@@ -877,7 +901,8 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
877901
.zip(crates)
878902
.zip(perfect_matches)
879903
.zip(recent_downloads)
880-
.map(|(((max_version, krate), perfect_match), recent_downloads)| {
904+
.map(|(((max_version, krate), perfect_match),
905+
recent_downloads)| {
881906
// FIXME: If we add crate_id to the Badge enum we can eliminate
882907
// this N+1
883908
let badges = badges::table

src/tests/all.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,9 @@ impl<'a> CrateBuilder<'a> {
393393
date: old_date,
394394
};
395395

396-
insert(&crate_download).into(crate_downloads::table).execute(connection)?;
396+
insert(&crate_download)
397+
.into(crate_downloads::table)
398+
.execute(connection)?;
397399
krate.downloads = downloads;
398400
update(&krate).set(&krate).execute(connection)?;
399401
}
@@ -405,7 +407,9 @@ impl<'a> CrateBuilder<'a> {
405407
date: now.naive_utc().date(),
406408
};
407409

408-
insert(&crate_download).into(crate_downloads::table).execute(connection)?;
410+
insert(&crate_download)
411+
.into(crate_downloads::table)
412+
.execute(connection)?;
409413
}
410414

411415
if self.versions.is_empty() {

src/tests/krate.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,9 @@ fn exact_match_on_queries_with_sort() {
366366
assert_eq!(json.crates[3].name, "foo_sort");
367367

368368
// Sort by recent-downloads
369-
let mut response = ok_resp!(middle.call(req.with_query("q=bar_sort&sort=recent-downloads")));
369+
let mut response = ok_resp!(middle.call(
370+
req.with_query("q=bar_sort&sort=recent-downloads"),
371+
));
370372
let json: CrateList = ::json(&mut response);
371373
assert_eq!(json.meta.total, 3);
372374
assert_eq!(json.crates[0].name, "bar_sort");
@@ -1964,7 +1966,7 @@ fn test_recent_download_count() {
19641966

19651967
let mut req = ::req(app, Method::Get, "/api/v1/crates");
19661968
let mut response = ok_resp!(middle.call(req.with_query("sort=recent-downloads")));
1967-
let json:CrateList = ::json(&mut response);
1969+
let json: CrateList = ::json(&mut response);
19681970

19691971
assert_eq!(json.meta.total, 2);
19701972

@@ -2000,7 +2002,7 @@ fn test_zero_downloads() {
20002002

20012003
let mut req = ::req(app, Method::Get, "/api/v1/crates");
20022004
let mut response = ok_resp!(middle.call(req.with_query("sort=recent-downloads")));
2003-
let json:CrateList = ::json(&mut response);
2005+
let json: CrateList = ::json(&mut response);
20042006

20052007
assert_eq!(json.meta.total, 1);
20062008

@@ -2043,7 +2045,7 @@ fn test_default_sort_recent() {
20432045
// by default
20442046
let mut req = ::req(app.clone(), Method::Get, "/api/v1/crates");
20452047
let mut response = ok_resp!(middle.call(req.with_query("keyword=dog")));
2046-
let json:CrateList = ::json(&mut response);
2048+
let json: CrateList = ::json(&mut response);
20472049

20482050
assert_eq!(json.meta.total, 2);
20492051

@@ -2068,7 +2070,7 @@ fn test_default_sort_recent() {
20682070
// test that index for categories is sorted by recent_downloads
20692071
// by default
20702072
let mut response = ok_resp!(middle.call(req.with_query("category=animal")));
2071-
let json:CrateList = ::json(&mut response);
2073+
let json: CrateList = ::json(&mut response);
20722074

20732075
assert_eq!(json.meta.total, 2);
20742076

0 commit comments

Comments
 (0)