Skip to content

Allow changing the bug report url for the ice hook #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
bjorn3 opened this issue Jun 3, 2021 · 3 comments
Closed
1 of 3 tasks

Allow changing the bug report url for the ice hook #436

bjorn3 opened this issue Jun 3, 2021 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jun 3, 2021

Proposal

The bug report url is currently hard-coded to https://github.com/rust-lang/rust/issues/new. This is a sensible location for rustc and other official users of rustc_driver, but in case of external tools there is a big chance that the ICE is actually caused by the tool and not rustc. For this reason it makes sense to allow changing the bug report url for the ice hook.

This is implemented in rust-lang/rust#85640.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@bjorn3 bjorn3 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jun 3, 2021
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 3, 2021
@bjorn3 bjorn3 mentioned this issue Jun 3, 2021
Merged
@jonas-schievink
Copy link
Contributor

Since you can already override the panic hook with your own, and print the URL there, this seems like a reasonable addition

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 3, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 10, 2021
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jun 29, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @apiraino @bjorn3 @rustbot