Skip to content

Commit 7d93adb

Browse files
authored
Merge pull request #224 from rust-lang/run-all
Run gimli tests without debuginfo on Azure again
2 parents 3f854f7 + 6482e2d commit 7d93adb

File tree

3 files changed

+233
-132
lines changed

3 files changed

+233
-132
lines changed

Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ cpp_demangle = { default-features = false, version = "0.2.3", optional = true }
3333
addr2line = { version = "0.9.0", optional = true, default-features = false, features = ['std'] }
3434
findshlibs = { version = "0.5.0", optional = true }
3535
memmap = { version = "0.7.0", optional = true }
36-
goblin = { version = "0.0.22", optional = true, default-features = false, features = ['std'] }
36+
goblin = { version = "0.0.23", optional = true, default-features = false, features = ['std'] }
3737

3838
[target.'cfg(windows)'.dependencies]
3939
winapi = { version = "0.3.3", optional = true }
40-
goblin = { version = "0.0.22", optional = true, default-features = false, features = ['pe32', 'pe64'] }
40+
goblin = { version = "0.0.23", optional = true, default-features = false, features = ['pe32', 'pe64'] }
4141
[target.'cfg(target_os = "macos")'.dependencies]
42-
goblin = { version = "0.0.22", optional = true, default-features = false, features = ['mach32', 'mach64'] }
42+
goblin = { version = "0.0.23", optional = true, default-features = false, features = ['mach32', 'mach64'] }
4343
[target.'cfg(not(any(target_os = "macos", windows)))'.dependencies]
44-
goblin = { version = "0.0.22", optional = true, default-features = false, features = ['elf32', 'elf64'] }
44+
goblin = { version = "0.0.23", optional = true, default-features = false, features = ['elf32', 'elf64'] }
4545

4646
# Each feature controls the two phases of finding a backtrace: getting a
4747
# backtrace and then resolving instruction pointers to symbols. The default

ci/azure-test-all.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,5 @@ steps:
5353
displayName: "Test without debuginfo (libbacktrace)"
5454
- bash: cd ./crates/without_debuginfo && cargo test --features 'libbacktrace coresymbolication'
5555
displayName: "Test without debuginfo (coresymbolication)"
56-
# TODO: there's a bug on stable Rust right now (1.35.0) which prevents testing
57-
# gimli here, so disable this temporarily until 1.36.0 is released.
58-
# - bash: cd ./crates/without_debuginfo && cargo test --features 'libbacktrace gimli-symbolize'
59-
# displayName: "Test without debuginfo (gimli-symbolize)"
56+
- bash: cd ./crates/without_debuginfo && cargo test --features 'libbacktrace gimli-symbolize'
57+
displayName: "Test without debuginfo (gimli-symbolize)"

0 commit comments

Comments
 (0)