Move periodic update check start logic to startServerProcess

Author: alexheretic

lib/index.js

@@ -479,17 +479,6 @@ class RustLanguageClient extends AutoLanguageClient {
       () => this._restartLanguageServers().catch(logErr)
     ))
 
-    // check for updates (if enabled) every so often
-    let periodicUpdateTimeoutId
-    const periodicUpdate = async () => {
-      await this._promptToUpdateToolchain().catch(logErr)
-      periodicUpdateTimeoutId = setTimeout(periodicUpdate, PERIODIC_UPDATE_CHECK_MILLIS)
-    }
-    this.disposables.add(new Disposable(() => {
-      clearTimeout(periodicUpdateTimeoutId)
-    }))
-    this._periodicUpdate = periodicUpdate
-
     this.disposables.add(atom.commands.add(
       'atom-workspace',
       'ide-rust:restart-all-language-servers',
@@ -544,10 +533,19 @@ class RustLanguageClient extends AutoLanguageClient {
   }
 
   async startServerProcess(projectPath) {
-    if (this._periodicUpdate) {
-      // if haven't started checking for updates yet start now
-      this._periodicUpdate()
-      delete this._periodicUpdate
+    if (!this._periodicUpdateChecking) {
+      // if haven't started periodic checks for updates yet start now
+      let periodicUpdateTimeoutId
+      const periodicUpdate = async () => {
+        await this._promptToUpdateToolchain().catch(logErr)
+        periodicUpdateTimeoutId = setTimeout(periodicUpdate, PERIODIC_UPDATE_CHECK_MILLIS)
+      }
+      this.disposables.add(new Disposable(() => {
+        clearTimeout(periodicUpdateTimeoutId)
+        delete this._periodicUpdateChecking
+      }))
+      this._periodicUpdateChecking = true
+      periodicUpdate().catch(logErr)
     }
 
     let cmdOverride = rlsCommandOverride()