Update crates/ide-db/src/syntax_helpers/node_ext.rs

Veykril · bm-w · web-flow · commit c0519daf3b05 · 2023-05-19T09:33:57.000+02:00
Co-authored-by: Bastiaan Marinus van de Weerd &lt;id@bm-w.eu&gt;
diff --git a/crates/ide-db/src/syntax_helpers/node_ext.rs b/crates/ide-db/src/syntax_helpers/node_ext.rs
@@ -52,9 +52,8 @@ pub fn preorder_expr(start: &ast::Expr, cb: &mut dyn FnMut(WalkEvent<ast::Expr>)
             }
         };
         if let Some(let_stmt) = node.parent().and_then(ast::LetStmt::cast) {
-            let node = Some(node.clone());
-            if node != let_stmt.initializer().map(|it| it.syntax().clone())
-                && node != let_stmt.let_else().map(|it| it.syntax().clone())
+            if let_stmt.initializer().map(|it| it.syntax() != &node).unwrap_or(true)
+                && let_stmt.let_else().map(|it| it.syntax() != &node).unwrap_or(true)
             {
                 // skipping potential const pat expressions in  let statements
                 preorder.skip_subtree();

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,8 @@ pub fn preorder_expr(start: &ast::Expr, cb: &mut dyn FnMut(WalkEvent<ast::Expr>)`
`52`	`52`	`}`
`53`	`53`	`};`
`54`	`54`	`if let Some(let_stmt) = node.parent().and_then(ast::LetStmt::cast) {`
`55`		`- let node = Some(node.clone());`
`56`		`- if node != let_stmt.initializer().map(\|it\| it.syntax().clone())`
`57`		`- && node != let_stmt.let_else().map(\|it\| it.syntax().clone())`
	`55`	`+ if let_stmt.initializer().map(\|it\| it.syntax() != &node).unwrap_or(true)`
	`56`	`+ && let_stmt.let_else().map(\|it\| it.syntax() != &node).unwrap_or(true)`
`58`	`57`	`{`
`59`	`58`	`// skipping potential const pat expressions in let statements`
`60`	`59`	`preorder.skip_subtree();`