split the Serial trait in two: serial::Read and serial::Write

Author: japaric

src/lib.rs

@@ -571,6 +571,7 @@
 extern crate nb;
 
 pub mod prelude;
+pub mod serial;
 
 /// Input capture
 ///
@@ -738,26 +739,6 @@ pub enum Direction {
     Upcounting,
 }
 
-/// Serial interface
-///
-/// Some serial interfaces support different data sizes (8 bits, 9 bits, etc.);
-/// This can be encoded in this trait via the `Word` type parameter.
-pub trait Serial<Word> {
-    /// Serial interface error
-    ///
-    /// Possible errors
-    ///
-    /// - *overrun*, the previous received data was overwritten because it was
-    ///   not read in a timely manner
-    type Error;
-
-    /// Reads a single word from the serial interface
-    fn read(&self) -> nb::Result<Word, Self::Error>;
-
-    /// Writes a single word to the serial interface
-    fn write(&self, word: Word) -> nb::Result<(), Self::Error>;
-}
-
 /// Serial Peripheral Interface (full duplex master mode)
 ///
 /// # Notes

src/prelude.rs

@@ -6,6 +6,7 @@
 pub use ::Capture as _embedded_hal_Capture;
 pub use ::Pwm as _embedded_hal_Pwm;
 pub use ::Qei as _embedded_hal_Qei;
-pub use ::Serial as _embedded_hal_Serial;
+pub use ::serial::Read as _embedded_hal_serial_Read;
+pub use ::serial::Write as _embedded_hal_serial_Write;
 pub use ::Spi as _embedded_hal_Spi;
 pub use ::Timer as _embedded_hal_Timer;

src/serial.rs

@@ -0,0 +1,29 @@
+//! Serial interface
+
+use nb;
+
+/// Read half of a serial interface
+///
+/// Some serial interfaces support different data sizes (8 bits, 9 bits, etc.);
+/// This can be encoded in this trait via the `Word` type parameter.
+pub trait Read<Word> {
+    /// Read error
+    ///
+    /// Possible errors
+    ///
+    /// - *overrun*, the previous received data was overwritten because it was
+    ///   not read in a timely manner
+    type Error;
+
+    /// Reads a single word from the serial interface
+    fn read(&self) -> nb::Result<Word, Self::Error>;
+}
+
+/// Write half of a serial interface
+pub trait Write<Word> {
+    /// Write error
+    type Error;
+
+    /// Writes a single word to the serial interface
+    fn write(&self, word: Word) -> nb::Result<(), Self::Error>;
+}