Skip to content

Stronger focus on storage #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sympatron opened this issue Dec 10, 2020 · 0 comments
Closed

Stronger focus on storage #2

Sympatron opened this issue Dec 10, 2020 · 0 comments

Comments

@Sympatron
Copy link
Contributor

Sympatron commented Dec 10, 2020 •
edited
Loading

First off, I am glad this finally got it's own repository so progress can be made in this area.

I would vote to remove most of the traits currently in this crate or at least move them to a sub-module, because they are not directly related to storage.

  • BitSubset (almost) completely unrelated IMO.
  • I don't think Add<Address> should be implemented for Address. Semantically this makes no sense. Add<isize> and Sub<usize>/Sub<isize> would be useful on the other hand.
  • Region is related to storage, but I am not entirely convinced it has to be a trait, except you want to support disjoint regions?
  • I have to admit I don't fully understand the purpose of OverlapIterator, but I don't really see the value for users of this crate. Please correct me if I am wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sympatron