Skip to content

Commit 2a83fa0

Browse files
committed
Update MSRV in CI and Readme from 1.29 to 1.41.1
It seems we have consensus within the rust-bitcoin github organisation on bumping the MSRV to 1.41.1, update CI job and the README to reflect this.
1 parent 2b73bb2 commit 2a83fa0

File tree

2 files changed

+3
-28
lines changed

2 files changed

+3
-28
lines changed

.github/workflows/rust.yml

+1-8
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
strategy:
5555
matrix:
5656
rust:
57-
- 1.29.0
57+
- 1.41.1
5858
- beta
5959
steps:
6060
- name: Checkout Crate
@@ -65,13 +65,6 @@ jobs:
6565
profile: minimal
6666
toolchain: ${{ matrix.rust }}
6767
override: true
68-
- name: Pin deps if rust 1.29
69-
if: matrix.rust == '1.29.0'
70-
run: |
71-
cargo generate-lockfile --verbose && \
72-
cargo update --verbose --package "cc" --precise "1.0.41" && \
73-
cargo update --verbose --package "serde" --precise "1.0.98" && \
74-
cargo update --verbose --package "serde_derive" --precise "1.0.98"
7568
- name: Running cargo
7669
run: ./contrib/test.sh
7770

README.md

+2-20
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
![Build](https://github.com/rust-bitcoin/rust-miniscript/workflows/Continuous%20integration/badge.svg)
22

3-
**Minimum Supported Rust Version:** 1.29.0
4-
5-
*This crate uses "2015" edition and won't be ported over "2018" edition
6-
in the near future as this will change the MSRV to 1.31.*
3+
**Minimum Supported Rust Version:** 1.41.1
74

85
# Miniscript
96

@@ -36,22 +33,7 @@ or in [the `examples/` directory](https://github.com/apoelstra/rust-miniscript/t
3633

3734

3835
## Minimum Supported Rust Version (MSRV)
39-
This library should always compile with any combination of features on **Rust 1.29**.
40-
41-
Because some dependencies have broken the build in minor/patch releases, to compile with 1.29.0 you will need to
42-
generate the lockfile and run the following version-pinning command:
43-
```
44-
cargo generate-lockfile --verbose
45-
cargo update -p cc --precise "1.0.41" --verbose
46-
```
47-
48-
In order to use the `use-serde` feature or to build the unit tests with 1.29.0,
49-
the following version-pinning commands are also needed:
50-
```
51-
cargo update --package "serde" --precise "1.0.98"
52-
cargo update --package "serde_derive" --precise "1.0.98"
53-
```
54-
36+
This library should always compile with any combination of features on **Rust 1.41.1**.
5537

5638
## Contributing
5739
Contributions are generally welcome. If you intend to make larger changes please

0 commit comments

Comments
 (0)