Skip to content

[Peers] Feature: BOLT1 MAY FAIL if pong bytes_len does not match #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #707
julianknutsen opened this issue Sep 16, 2020 · 1 comment
Open
Tracked by #707

Comments

@julianknutsen
Copy link

The current implementation doesn’t check the pong and always sends a bytes_len of 64.

What is the value of implementing this feature? Should we document anywhere that we are intentionally doing nothing?

@julianknutsen julianknutsen mentioned this issue Sep 16, 2020
18 tasks
@TheBlueMatt
Copy link
Collaborator

The current implementation doesn’t check the pong
always sends a bytes_len of 64.

These seem like two separate issues - the spec seems to be referencing checking that the size of the received pong is the size that we expect (which we should be doing?). As for the sending side, we should probably stop setting it to 64 and wasting bytes and always set it to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants