Skip to content

[Peers] Feature: Add Channel/Node/Update forwarding #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #707
julianknutsen opened this issue Sep 16, 2020 · 1 comment
Closed
Tracked by #707

[Peers] Feature: Add Channel/Node/Update forwarding #702

julianknutsen opened this issue Sep 16, 2020 · 1 comment

Comments

@julianknutsen
Copy link

As a message handler, I want to forward certain messages to known initialized peers if the route_handler allows it.

Definition of Done:

  • Unit tests are updated to include tests that validate message is forwarded to (non-source?) initialized peers for:
    • wire::Message::ChannelAnnouncement
    • wire::Message::NodeAnnouncement
    • wire::Message::ChannelUpdate
  • Unit tests exist for the negative case as well when route_handler does not allow it.

Tech Discussion:
TODO from the codebase. Similar to the event path, if the route_handler allows it, broadcast the message to all known initialized peers.

Route handler stubs already exist so the testing should be straight forward. A little bit of work to create multiple initialized peers.

Recommend this is done AFTER the unit test work on message handling to get the testing in a better place. Will require a dependency update due to needing an InitializedPeerProvider instead of just the Peer, but should be straight forward.

@julianknutsen julianknutsen mentioned this issue Sep 16, 2020
18 tasks
@TheBlueMatt
Copy link
Collaborator

Not sure if this was done at the time this issue was opened, but its definitely done now, even with rate-limiting and all the good stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants