You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given RPC method foobar returning type FooBar with conversion error FooBarError.
Our integration testing strategy verifies that FooBar is re-exported correctly. If FooBar has a field with type FooBarAuxType then we do not currently verify that it is correctly re-exported - i would be nice to come up with a way to prove we got it right. Extremely high chance I made mistakes in this area. Not super likely downstream will notice.
The text was updated successfully, but these errors were encountered:
One way I am thinking is to also use the explicit type check we are using for the normal types. But it might make the test clumsy. To avoid this, I am thinking of creating another test file to check that all re-exports is done correctly including the Auxiliary types.
Another way I am looking at is to use a custom macro method of assert_field_is_exact_type!, which we can define and then call for each re-exported types having auxiliary types.
tcharding
changed the title
Test that re-exported types auxiliary types are correct
verify: Test that re-exported types auxiliary types are correct
May 12, 2025
Given RPC method
foobar
returning typeFooBar
with conversion errorFooBarError
.Our integration testing strategy verifies that
FooBar
is re-exported correctly. IfFooBar
has a field with typeFooBarAuxType
then we do not currently verify that it is correctly re-exported - i would be nice to come up with a way to prove we got it right. Extremely high chance I made mistakes in this area. Not super likely downstream will notice.The text was updated successfully, but these errors were encountered: