Filter out hidden and extensionless files from watching

Author: vipentti

src/io.rs

@@ -7,7 +7,7 @@ use std::{
 };
 use crossbeam_channel::{Sender, Receiver, unbounded, RecvError, select};
 use relative_path::RelativePathBuf;
-use walkdir::WalkDir;
+use walkdir::{WalkDir, DirEntry};
 use notify::{DebouncedEvent, RecommendedWatcher, RecursiveMode, Watcher as _Watcher};
 
 use crate::{Roots, VfsRoot, VfsTask};
@@ -250,6 +250,14 @@ fn handle_change(
     }
 }
 
+fn is_extensionless_file(entry: &DirEntry) -> bool {
+    entry.file_type().is_file() && entry.path().extension().is_none()
+}
+
+fn is_hidden(entry: &DirEntry) -> bool {
+    entry.file_name().to_str().map(|s| s.starts_with(".")).unwrap_or(false)
+}
+
 fn watch_recursive(
     mut watcher: Option<&mut RecommendedWatcher>,
     dir: &Path,
@@ -259,7 +267,11 @@ fn watch_recursive(
     let mut files = Vec::new();
     for entry in WalkDir::new(dir)
         .into_iter()
-        .filter_entry(|it| roots.contains(root, it.path()).is_some())
+        .filter_entry(|it| {
+            !is_hidden(it)
+                && !is_extensionless_file(it)
+                && roots.contains(root, it.path()).is_some()
+        })
         .filter_map(|it| it.map_err(|e| log::warn!("watcher error: {}", e)).ok())
     {
         if entry.file_type().is_dir() {

tests/vfs.rs

@@ -44,7 +44,14 @@ macro_rules! assert_match {
 fn test_vfs_works() -> std::io::Result<()> {
     // Logger::with_str("vfs=debug,ra_vfs=debug").start().unwrap();
 
-    let files = [("a/foo.rs", "hello"), ("a/bar.rs", "world"), ("a/b/baz.rs", "nested hello")];
+    let files = [
+        ("a/foo.rs", "hello"),
+        ("a/bar.rs", "world"),
+        ("a/b/baz.rs", "nested hello"),
+        ("a/LICENSE", "extensionless file"),
+        ("a/b/AUTHOR", "extensionless file"),
+        ("a/.hidden.txt", "hidden file"),
+    ];
 
     let dir = tempdir().unwrap();
     for (path, text) in files.iter() {