Version Patch #39
Merged
Version Patch #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyrillkalita
commented
Sep 26, 2020
cyrillkalita
commented
- Update dependency to support Laravel 8
- Add CHANGELOG.md
- Add composer scripts for testing and code fixing
- Add ignore of .php_cs.cache
- Apply PSR style formatting
- Update dependency to support Laravel 8 - Add [CHANGELOG.md](CHANGELOG.md) - Add composer scripts for testing and code fixing - Add ignore of .php_cs.cache - Apply PSR style formatting
|
@rtconner Rob, is there anything stopping the merge? |
Owner
|
just lack of time on my part. sorry. I didn't even see this PR. what are all the white space changes? |
Owner
|
oh you probably did reformatting with phpstorm. I see. |
Contributor
Author
|
@rtconner I ran the code through phpcs. |
Contributor
Author
|
@rtconner do you think you may be able to review it any time soon? |
rtconner
reviewed
Oct 13, 2020
Owner
rtconner
left a comment
rtconner
left a comment
There was a problem hiding this comment.
Ok this is released as version 3.1.0.
Thank you!
| ```php | ||
| class Article extends \Illuminate\Database\Eloquent\Model { | ||
| use \Conner\Likeable\LikeableTrait; | ||
| use \Conner\Likeable\Likeable; |
Owner
There was a problem hiding this comment.
wow, thanks for fixing this, I hadn't realized docs were wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.