Update cucumber #2518
Merged
Update cucumber #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
pirj
force-pushed
the
update-cucumber
branch
from
ab80912 to
b1aab4f
Compare
Otherwise, running `cucumber` won't filter scenarios, only `rake cucumber` will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cucumber4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it.cucumber3.2 would run on Ruby 2.2, 2.3 and 2.4.Running
cucumberwas not excluding features that don't match the current Rails version (@rails_pre_6/@rails_post_6).rake cucumberwas working fine.I've reworked this from
Rakefileto be aBeforeCucumber hook infeatures/support.Sibling PRs: