Skip to content

Updates rubocop to 0.79.0 #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2020
Merged

Updates rubocop to 0.79.0 #2251

merged 2 commits into from
Jan 7, 2020

Conversation

@RicardoTrindade
Copy link
Contributor

@RicardoTrindade RicardoTrindade commented Jan 6, 2020

Updating to rubocop 0.79.0, had to change the namespace from Metrics to Layout in LineLength

pirj
pirj approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@JonRowe JonRowe merged commit 86a5c1f into rspec:master Jan 7, 2020
@JonRowe
Copy link
Member

JonRowe commented Jan 7, 2020

Thanks @RicardoTrindade and thanks @pirj for the review, 🙏

JonRowe added a commit that referenced this pull request Jan 12, 2020
@JonRowe
Merge pull request #2251 from RicardoTrindade/bump_rubocop
cce6f9b 
Updates rubocop to 0.79.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pirj pirj pirj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RicardoTrindade @JonRowe @pirj