fixup! Revert changes breaking Rails 4.2 support

Author: pirj

example_app_generator/generate_app.rb

@@ -26,7 +26,9 @@
   gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.3.6'"
   gsub_file "Gemfile", /.*bootsnap.*/, ""
 
-  append_to_file('Gemfile', "gem 'rails-controller-testing'\n")
+  if Rails::VERSION::STRING >= '5.0.0'
+    append_to_file('Gemfile', "gem 'rails-controller-testing'\n")
+  end
 
   if Rails::VERSION::STRING >= '6'
     gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.4'"

lib/generators/rspec/mailer/templates/mailer_spec.rb

@@ -1,10 +1,10 @@
 require "rails_helper"
 
 <% module_namespacing do -%>
-RSpec.describe <%= class_name.sub(/(Mailer)?$/, 'Mailer') %>, <%= type_metatag(:mailer) %> do
+RSpec.describe <%= Rails.version.to_f >= 5.0 ? class_name.sub(/(Mailer)?$/, 'Mailer') : class_name %>, <%= type_metatag(:mailer) %> do
 <% for action in actions -%>
   describe "<%= action %>" do
-    let(:mail) { <%= class_name.sub(/(Mailer)?$/, 'Mailer') %>.<%= action %> }
+    let(:mail) { <%= Rails.version.to_f >= 5.0 ? class_name.sub(/(Mailer)?$/, 'Mailer') : class_name %>.<%= action %> }
 
     it "renders the headers" do
       expect(mail.subject).to eq(<%= action.to_s.humanize.inspect %>)

lib/generators/rspec/mailer/templates/preview.rb

@@ -5,7 +5,7 @@ class <%= class_name %>Preview < ActionMailer::Preview
 
   # Preview this email at http://localhost:3000/rails/mailers/<%= file_path %>/<%= action %>
   def <%= action %>
-    <%= class_name.sub(/(Mailer)?$/, 'Mailer') %>.<%= action %>
+    <%= Rails.version.to_f >= 5.0 ? class_name.sub(/(Mailer)?$/, 'Mailer') : class_name %>.<%= action %>
   end
 <% end -%>
 

lib/generators/rspec/scaffold/templates/controller_spec.rb

@@ -46,7 +46,11 @@
   describe "GET #index" do
     it "returns a success response" do
       <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+      get :index, {}, valid_session
+<% else -%>
       get :index, params: {}, session: valid_session
+<% end -%>
       expect(response).to be_successful
     end
   end
@@ -55,22 +59,34 @@
   describe "GET #show" do
     it "returns a success response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+      get :show, {id: <%= file_name %>.to_param}, valid_session
+<% else -%>
       get :show, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
       expect(response).to be_successful
     end
   end
 
   describe "GET #new" do
     it "returns a success response" do
+<% if Rails::VERSION::STRING < '5.0' -%>
+      get :new, {}, valid_session
+<% else -%>
       get :new, params: {}, session: valid_session
+<% end -%>
       expect(response).to be_successful
     end
   end
 
   describe "GET #edit" do
     it "returns a success response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+      get :edit, {id: <%= file_name %>.to_param}, valid_session
+<% else -%>
       get :edit, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
       expect(response).to be_successful
     end
   end
@@ -79,19 +95,31 @@
     context "with valid params" do
       it "creates a new <%= class_name %>" do
         expect {
+<% if Rails::VERSION::STRING < '5.0' -%>
+          post :create, {<%= ns_file_name %>: valid_attributes}, valid_session
+<% else -%>
           post :create, params: {<%= ns_file_name %>: valid_attributes}, session: valid_session
+<% end -%>
         }.to change(<%= class_name %>, :count).by(1)
       end
 
       it "redirects to the created <%= ns_file_name %>" do
+<% if Rails::VERSION::STRING < '5.0' -%>
+        post :create, {<%= ns_file_name %>: valid_attributes}, valid_session
+<% else -%>
         post :create, params: {<%= ns_file_name %>: valid_attributes}, session: valid_session
+<% end -%>
         expect(response).to redirect_to(<%= class_name %>.last)
       end
     end
 
     context "with invalid params" do
       it "returns a success response (i.e. to display the 'new' template)" do
+<% if Rails::VERSION::STRING < '5.0' -%>
+        post :create, {<%= ns_file_name %>: invalid_attributes}, valid_session
+<% else -%>
         post :create, params: {<%= ns_file_name %>: invalid_attributes}, session: valid_session
+<% end -%>
         expect(response).to be_successful
       end
     end
@@ -105,22 +133,34 @@
 
       it "updates the requested <%= ns_file_name %>" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+        put :update, {id: <%= file_name %>.to_param, <%= ns_file_name %>: new_attributes}, valid_session
+<% else -%>
         put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: new_attributes}, session: valid_session
+<% end -%>
         <%= file_name %>.reload
         skip("Add assertions for updated state")
       end
 
       it "redirects to the <%= ns_file_name %>" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+        put :update, {id: <%= file_name %>.to_param, <%= ns_file_name %>: valid_attributes}, valid_session
+<% else -%>
         put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: valid_attributes}, session: valid_session
+<% end -%>
         expect(response).to redirect_to(<%= file_name %>)
       end
     end
 
     context "with invalid params" do
       it "returns a success response (i.e. to display the 'edit' template)" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+        put :update, {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, valid_session
+<% else -%>
         put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, session: valid_session
+<% end -%>
         expect(response).to be_successful
       end
     end
@@ -130,13 +170,21 @@
     it "destroys the requested <%= ns_file_name %>" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
       expect {
+<% if Rails::VERSION::STRING < '5.0' -%>
+        delete :destroy, {id: <%= file_name %>.to_param}, valid_session
+<% else -%>
         delete :destroy, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
       }.to change(<%= class_name %>, :count).by(-1)
     end
 
     it "redirects to the <%= table_name %> list" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if Rails::VERSION::STRING < '5.0' -%>
+      delete :destroy, {id: <%= file_name %>.to_param}, valid_session
+<% else -%>
       delete :destroy, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
       expect(response).to redirect_to(<%= index_helper %>_url)
     end
   end

lib/rspec/rails/configuration.rb

@@ -79,8 +79,10 @@ def self.initialize_configuration(config)
       #   `RSpec::Rails::FixtureSupport` directly instead
       config.include RSpec::Rails::FixtureSupport
 
-      config.add_setting :file_fixture_path, default: 'spec/fixtures/files'
-      config.include RSpec::Rails::FileFixtureSupport
+      if ::Rails::VERSION::STRING > '5'
+        config.add_setting :file_fixture_path, default: 'spec/fixtures/files'
+        config.include RSpec::Rails::FileFixtureSupport
+      end
 
       # Add support for fixture_path on fixture_file_upload
       config.include RSpec::Rails::FixtureFileUploadSupport

lib/rspec/rails/file_fixture_support.rb

@@ -1,14 +1,16 @@
-require 'active_support/testing/file_fixtures'
+if ::Rails::VERSION::STRING > '5'
+  require 'active_support/testing/file_fixtures'
 
-module RSpec
-  module Rails
-    # @private
-    module FileFixtureSupport
-      extend ActiveSupport::Concern
-      include ActiveSupport::Testing::FileFixtures
+  module RSpec
+    module Rails
+      # @private
+      module FileFixtureSupport
+        extend ActiveSupport::Concern
+        include ActiveSupport::Testing::FileFixtures
 
-      included do
-        self.file_fixture_path = RSpec.configuration.file_fixture_path
+        included do
+          self.file_fixture_path = RSpec.configuration.file_fixture_path
+        end
       end
     end
   end

lib/rspec/rails/fixture_support.rb

@@ -11,7 +11,11 @@ module FixtureSupport
 
         included do
           self.fixture_path = RSpec.configuration.fixture_path
-          self.use_transactional_tests = RSpec.configuration.use_transactional_fixtures
+          if ::Rails::VERSION::STRING > '5'
+            self.use_transactional_tests = RSpec.configuration.use_transactional_fixtures
+          else
+            self.use_transactional_fixtures = RSpec.configuration.use_transactional_fixtures
+          end
           self.use_instantiated_fixtures = RSpec.configuration.use_instantiated_fixtures
 
           def self.fixtures(*args)

rspec-rails.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
     s.cert_chain = [File.expand_path('~/.gem/rspec-gem-public_cert.pem')]
   end
 
-  version_string = ['>= 5.0']
+  version_string = ['>= 4.2']
 
   s.add_runtime_dependency %q<activesupport>, version_string
   s.add_runtime_dependency %q<actionpack>,    version_string

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

@@ -110,8 +110,7 @@
       it { is_expected.to contain('assert_select "tr>td", text: 3.5.to_s, count: 2') }
     end
 
-    case
-    when Rails.version.to_f >= 5.1
+    if Rails.version.to_f >= 5.1
       describe 'with reference attribute' do
         before { run_generator %w(posts title:string author:references) }
         describe 'edit' do
@@ -126,7 +125,7 @@
           it { is_expected.to contain(/assert_select "input\[name=\?\]", "post\[title\]/) }
         end
       end
-    when Rails.version.to_f >= 5.0
+    else
       describe 'with reference attribute' do
         before { run_generator %w(posts title:string author:references) }
         describe 'edit' do