Skip to content

Suppress partial_writes deprecation warning #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Suppress partial_writes deprecation warning #2189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ def raise_make_transaction_rollback
expect(@employee.first_name).to eq("First")
end

it "should not update record if nothing is changed and partial writes are enabled" do
TestEmployee.partial_writes = true
it "should not update record if nothing is changed and partial updates are enabled" do
TestEmployee.partial_updates = true
@employee = TestEmployee.create(
first_name: "First",
last_name: "Last",
Expand All @@ -223,8 +223,8 @@ def raise_make_transaction_rollback
expect(@employee.version).to eq(1)
end

it "should update record if nothing is changed and partial writes are disabled" do
TestEmployee.partial_writes = false
it "should update record if nothing is changed and partial updates are disabled" do
TestEmployee.partial_updates = false
@employee = TestEmployee.create(
first_name: "First",
last_name: "Last",
Expand Down Expand Up @@ -316,7 +316,7 @@ def raise_make_transaction_rollback
end

it "should log update record" do
(TestEmployee.partial_writes = false) rescue nil
(TestEmployee.partial_updates = false) rescue nil
@employee = TestEmployee.create(
first_name: "First",
last_name: "Last",
Expand Down