Skip to content

Commit e5bf239

Browse files
authored
Merge pull request #2114 from yahonda/backport_2109_to_release60
Merge pull request #2109 from joshpencheon/fix-fk-structure-dump-incl…
2 parents edbacb8 + 893df2d commit e5bf239

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ def structure_dump #:nodoc:
5555
structure << structure_dump_column_comments(table_name)
5656
end
5757

58-
join_with_statement_token(structure) << structure_dump_fk_constraints
59-
join_with_statement_token(structure) << structure_dump_views
58+
join_with_statement_token(structure) <<
59+
structure_dump_fk_constraints <<
60+
structure_dump_views
6061
end
6162

6263
def structure_dump_column(column) #:nodoc:

spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class ::TestPost < ActiveRecord::Base
6666
ALTER TABLE TEST_POSTS
6767
ADD CONSTRAINT fk_test_post_foo FOREIGN KEY (foo_id) REFERENCES foos(id)
6868
SQL
69-
dump = ActiveRecord::Base.connection.structure_dump_fk_constraints
69+
dump = ActiveRecord::Base.connection.structure_dump
7070
expect(dump.split('\n').length).to eq(1)
7171
expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_FOO\"? FOREIGN KEY \(\"?FOO_ID\"?\) REFERENCES \"?FOOS\"?\(\"?ID\"?\)/i)
7272
end
@@ -86,7 +86,7 @@ class ::TestPost < ActiveRecord::Base
8686
ADD CONSTRAINT fk_test_post_baz FOREIGN KEY (baz_id) REFERENCES foos(baz_id)
8787
SQL
8888

89-
dump = ActiveRecord::Base.connection.structure_dump_fk_constraints
89+
dump = ActiveRecord::Base.connection.structure_dump
9090
expect(dump.split('\n').length).to eq(1)
9191
expect(dump).to match(/ALTER TABLE \"?TEST_POSTS\"? ADD CONSTRAINT \"?FK_TEST_POST_BAZ\"? FOREIGN KEY \(\"?BAZ_ID\"?\) REFERENCES \"?FOOS\"?\(\"?BAZ_ID\"?\)/i)
9292
end

0 commit comments

Comments
 (0)