Skip to content

Bug fixes for ggplot2 (> 1.0.1) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 75 commits into from
Dec 18, 2015
Merged

Bug fixes for ggplot2 (> 1.0.1) #269

merged 75 commits into from
Dec 18, 2015

Conversation

cpsievert
Copy link
Collaborator

I was trying to do too much in #264. This will focus solely on fixing bugs that the dev version of ggplot2 introduces.

@cpsievert cpsievert changed the title Fix backwards incompatible changes made to ggplot2 internals. Bug fixes for ggplot2 (> 1.0.1) Aug 18, 2015
@cpsievert cpsievert mentioned this pull request Sep 4, 2015
Closed
@cpsievert
new scales is on CRAN; another fix for ggplot_build2()
67baf3d
@cpsievert
attempt at fixing #268
b4427e0
@cpsievert
missing s
1503c1c
@cpsievert
Merge branch 'master' of https://github.com/ropensci/plotly into fix-…
fd0b05c 
…ggplot2
@cpsievert
Merge branch 'images-test' of https://github.com/ropensci/plotly into…
57866b0 
… fix-ggplot2
@cpsievert
maybe we now have to get paramter values from the data?
36956c4
@cpsievert
Just like plotly_build(). ggplotly() should tag special properties to…
f94dc5e 
… not be unboxed
@cpsievert
Messing around with sizing
d565f30
@cpsievert
Moar fixes for geom_point
5d2d6c7
@cpsievert
Tsting for a NA color is too specific
6b0d1dc
@cpsievert
Write JSON to disk (instead of downloading figure from server) in ord…
2634b53 
…er to build diff pages
@cpsievert
Merge branch 'images-test' of https://github.com/ropensci/plotly into…
1e7d8af 
… fix-ggplot2
@cpsievert
Don't run image examples
52650f3
@cpsievert
More careful approach to 'unboxing' gg2list() output
2e130cd
@cpsievert
server can't handle empty keyword args
170723c
@cpsievert
import stats::setNames
53aa318
@cpsievert
Bug fixes
6d43c3e
@cpsievert
hline/vline/abline are all paths, fixes for boxplot
509e50f
@cpsievert
merge conflict
e5e49bb
@cpsievert
Mor fun with file naming
7a5826c
@cpsievert
Test fixes for abline/hline/vline
520f75f
@cpsievert
grab parameter defaults from data; test cleanup
262d0a1
@cpsievert
boxplot hack no longer necessary
d812c84
@cpsievert
no longer need to grab parameters from data within specific geoms
08cbabf
@cpsievert
It's possible to have a character string represent a missing value
1c47d1c
@cpsievert
ggplot2::geom_*() no longer allows passing arbitrary arguments
483552a
@cpsievert cpsievert mentioned this pull request Dec 12, 2015
Closed
@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/97727918

Detected 212 differences ->

http://cpsievert.github.io/plotly-test-table/03d2082/area
http://cpsievert.github.io/plotly-test-table/03d2082/area-fillcolor
http://cpsievert.github.io/plotly-test-table/03d2082/area-traces_order
http://cpsievert.github.io/plotly-test-table/03d2082/bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/03d2082/bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/03d2082/bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/03d2082/bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/03d2082/bar-black-outline
http://cpsievert.github.io/plotly-test-table/03d2082/bar-category-names
http://cpsievert.github.io/plotly-test-table/03d2082/bar-color
http://cpsievert.github.io/plotly-test-table/03d2082/bar-dates
http://cpsievert.github.io/plotly-test-table/03d2082/bar-dodge
http://cpsievert.github.io/plotly-test-table/03d2082/bar-factor-category
http://cpsievert.github.io/plotly-test-table/03d2082/bar-identity
http://cpsievert.github.io/plotly-test-table/03d2082/bar-nocolor
http://cpsievert.github.io/plotly-test-table/03d2082/bar-position-fill
http://cpsievert.github.io/plotly-test-table/03d2082/bar-position-stack
http://cpsievert.github.io/plotly-test-table/03d2082/bar-stack
http://cpsievert.github.io/plotly-test-table/03d2082/boxplot
http://cpsievert.github.io/plotly-test-table/03d2082/boxplot-datetime
http://cpsievert.github.io/plotly-test-table/03d2082/boxplot-fillcolor
http://cpsievert.github.io/plotly-test-table/03d2082/boxplot-legends_for_fill
http://cpsievert.github.io/plotly-test-table/03d2082/contour
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-blank-minor
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-blank-minor-major
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-blank-x
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-blank-y
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-coord-ylim
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-custom-formatter
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-flevels
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-label-funs
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-multiple-abline
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-scale.hide
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-scale-name
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-single-abline
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-axes-ylim.hide
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/03d2082/cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/03d2082/date-class-Date
http://cpsievert.github.io/plotly-test-table/03d2082/date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/03d2082/date-strings
http://cpsievert.github.io/plotly-test-table/03d2082/density2d
http://cpsievert.github.io/plotly-test-table/03d2082/density-color
http://cpsievert.github.io/plotly-test-table/03d2082/density-fill
http://cpsievert.github.io/plotly-test-table/03d2082/density-histogram
http://cpsievert.github.io/plotly-test-table/03d2082/density-simple
http://cpsievert.github.io/plotly-test-table/03d2082/density-traces_order
http://cpsievert.github.io/plotly-test-table/03d2082/errorbar
http://cpsievert.github.io/plotly-test-table/03d2082/errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/03d2082/facet_grid_free
http://cpsievert.github.io/plotly-test-table/03d2082/facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/03d2082/facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/03d2082/facet_wrap_free
http://cpsievert.github.io/plotly-test-table/03d2082/facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/03d2082/facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/03d2082/heatmap
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-counts
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-dates
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-density
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fill
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/03d2082/histogram-vline
http://cpsievert.github.io/plotly-test-table/03d2082/hline
http://cpsievert.github.io/plotly-test-table/03d2082/hline-factor
http://cpsievert.github.io/plotly-test-table/03d2082/hline-multiple
http://cpsievert.github.io/plotly-test-table/03d2082/jitter-basic
http://cpsievert.github.io/plotly-test-table/03d2082/labels-angles
http://cpsievert.github.io/plotly-test-table/03d2082/labels-ggtitle
http://cpsievert.github.io/plotly-test-table/03d2082/labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/03d2082/labels-ylab
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-default
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/03d2082/legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/03d2082/legend-many-legend-items
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-lines_points_different_legend_name
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-lines_points_same_legend_name2
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_different_legend_names_2_factors
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_labs_different_legend_names
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_no_user_generated_legend_name
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_no_user_generated_legend_name_2_factors
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_same_legend_name
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_scale_different_legend_names
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_scale_lab_same_legend_name
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_scale_lab_same_legend_name2
http://cpsievert.github.io/plotly-test-table/03d2082/legend_name-scatter_scale_same_legend_name
http://cpsievert.github.io/plotly-test-table/03d2082/legend-very-long-legend-items
http://cpsievert.github.io/plotly-test-table/03d2082/linetype-colors
http://cpsievert.github.io/plotly-test-table/03d2082/linetype-types
http://cpsievert.github.io/plotly-test-table/03d2082/object_environments-annotations
http://cpsievert.github.io/plotly-test-table/03d2082/object_environments-bargap
http://cpsievert.github.io/plotly-test-table/03d2082/object_environments-increase_margin_r
http://cpsievert.github.io/plotly-test-table/03d2082/path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/03d2082/path-colors
http://cpsievert.github.io/plotly-test-table/03d2082/path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/03d2082/path-line-symbols
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-aes-color
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-black
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/03d2082/polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-star-group
http://cpsievert.github.io/plotly-test-table/03d2082/polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/03d2082/rect-black
http://cpsievert.github.io/plotly-test-table/03d2082/rect-black4
http://cpsievert.github.io/plotly-test-table/03d2082/rect-color
http://cpsievert.github.io/plotly-test-table/03d2082/rect-fill
http://cpsievert.github.io/plotly-test-table/03d2082/rect-fill-color
http://cpsievert.github.io/plotly-test-table/03d2082/ribbon-alpha
http://cpsievert.github.io/plotly-test-table/03d2082/ribbon-colour
http://cpsievert.github.io/plotly-test-table/03d2082/ribbon-fill
http://cpsievert.github.io/plotly-test-table/03d2082/ribbon-group
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-color
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-geom_jitter
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-loess
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-shape
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/03d2082/scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/03d2082/segment
http://cpsievert.github.io/plotly-test-table/03d2082/segment-multiple-non-numeric
http://cpsievert.github.io/plotly-test-table/03d2082/size-global-scaling
http://cpsievert.github.io/plotly-test-table/03d2082/size-is-a-vector
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-basic
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-colour
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-colour2
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-facet
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-fill2
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-group
http://cpsievert.github.io/plotly-test-table/03d2082/smooth-se-false
http://cpsievert.github.io/plotly-test-table/03d2082/stack
http://cpsievert.github.io/plotly-test-table/03d2082/stack-identical
http://cpsievert.github.io/plotly-test-table/03d2082/step-gg.hv
http://cpsievert.github.io/plotly-test-table/03d2082/step-gg.hvh
http://cpsievert.github.io/plotly-test-table/03d2082/step-gg.vh
http://cpsievert.github.io/plotly-test-table/03d2082/step-gg.vhv
http://cpsievert.github.io/plotly-test-table/03d2082/text
http://cpsievert.github.io/plotly-test-table/03d2082/text-colour
http://cpsievert.github.io/plotly-test-table/03d2082/theme-background
http://cpsievert.github.io/plotly-test-table/03d2082/theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/03d2082/theme-marker-default
http://cpsievert.github.io/plotly-test-table/03d2082/theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/03d2082/theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/03d2082/theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/03d2082/theme-ticks-default
http://cpsievert.github.io/plotly-test-table/03d2082/theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-boxes
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-boxes-facet-grid
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-boxes-scales-free
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-boxes-space-free
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-breaks-less
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-breaks-more
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-breaks-nochange
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-discrete-order
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-evenly-spaced-ticks
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-flip
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-hide-ticks-lines-labels
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-hide-y
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-limits-gap
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-limits-hide
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-scale-labels
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-ycontinuous-ranges
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-ylim-ranges
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-ylim-reversed-ranges
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-yreverse-limits-ranges
http://cpsievert.github.io/plotly-test-table/03d2082/ticks-yreverse-ranges
http://cpsievert.github.io/plotly-test-table/03d2082/violin
http://cpsievert.github.io/plotly-test-table/03d2082/vline
http://cpsievert.github.io/plotly-test-table/03d2082/vline-multiple
http://cpsievert.github.io/plotly-test-table/03d2082/ylim-one-trace

cpsievert added a commit that referenced this pull request Dec 18, 2015
@cpsievert
Merge pull request #269 from ropensci/fix-ggplot2
786f8e6 
Bug fixes for ggplot2 (> 1.0.1)
@cpsievert cpsievert merged commit 786f8e6 into master Dec 18, 2015
@cpsievert cpsievert deleted the fix-ggplot2 branch March 13, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cpsievert