feat: Add new property argsString.

* feat: add new property argsString

* fix: error when no argString property

* refactor: wrap arguments in a function

* refactor: use shell-quote to parse args array

And also perform the argsString validation at extension.ts.

* chore: clean changed files wrongly

* chore: add execution permission to bashdb

* format: delete space in import

Author: felipecrs

bashdb_dir/bashdb

@@ -48,6 +48,7 @@
   "dependencies": {
     "child-process": "^1.0.2",
     "npm-which": "^3.0.1",
+    "shell-quote": "^1.7.2",
     "vscode-debugadapter": "1.38.0",
     "vscode-debugprotocol": "1.38.0"
   },
@@ -101,9 +102,14 @@
             "properties": {
               "args": {
                 "// type: Array<string> -> warning `Incorrect type. Expected Array<string>` in launch.json": null,
-                "description": "Command line arguments. (i.e. [\"--opt\", \"arg\"])",
+                "description": "Command line arguments in array of strings format. (i.e. [\"--opt\", \"arg\"])",
                 "default": []
               },
+              "argsString": {
+                "// type: string -> warning `Incorrect type. Expected string` in launch.json": null,
+                "description": "Command line arguments in string format. (i.e. \"--opt arg\"]. The arguments in this string will be appended to the arguments of `args`, if present.)",
+                "default": ""
+              },
               "cwd": {
                 "type": "string",
                 "description": "Working directory. (i.e. `cd $cwd; bashdb <options> $program` will be executed internally).",

package-lock.json

@@ -12,10 +12,12 @@ import { validatePath } from './bashRuntime';
 import { getWSLPath, reverseWSLPath, escapeCharactersInBashdbArg, getWSLLauncherPath } from './handlePath';
 import { EventSource } from './eventSource';
 import { spawnBashScript } from './spawnBash';
+import { quote } from 'shell-quote'
 
 export interface LaunchRequestArguments extends DebugProtocol.LaunchRequestArguments {
 
 	// Non-optional arguments are guaranteed to be defined in extension.ts: resolveDebugConfiguration().
+	argsString: string;
 	args: string[];
 	env: object;
 	cwd: string;
@@ -151,7 +153,7 @@ export class BashDebugSession extends LoggingDebugSession {
 		const command = this.joinCommands(
 			`${envVars}cd "${args.cwdEffective}"`,
 			`while [[ ! -p "${fifo_path}" ]]; do sleep 0.25; done`,
-			`"${args.pathBash}" "${args.pathBashdb}" --quiet --tty "${fifo_path}" --tty_in "${fifo_path}_in" --library "${args.pathBashdbLib}" -- "${args.programEffective}" ${args.args.map(e => `"` + e.replace(`"`, `\\\"`) + `"`).join(` `)}`);
+			`"${args.pathBash}" "${args.pathBashdb}" --quiet --tty "${fifo_path}" --tty_in "${fifo_path}_in" --library "${args.pathBashdbLib}" -- "${args.programEffective}" ${quote(args.args)} ${args.argsString}`);
 
 		if (this.launchArgs.terminalKind === "debugConsole" || this.launchArgs.terminalKind === undefined) {
 			spawnBashScript(

package.json

@@ -88,6 +88,10 @@ class BashConfigurationProvider implements vscode.DebugConfigurationProvider {
 			return vscode.window.showErrorMessage("Please specify `args` as array of strings in launch.json.").then(_ => { return undefined; });
 		}
 
+		if (!config.argsString) {
+			config.argsString = "";
+		}
+
 		if (!config.env) { config.env = {}; }
 		if (!config.cwd) {
 			if (!folder) {