Skip to content

Commit 05d78cf

Browse files
authored
postmortem for 0.5.0a0 (#75)
* postmortem for 0.5.0a0 * build with SOURCE_DATE_EPOCH * add additional element check, timeout for notebook tree * normalize recipe from conda-forge
1 parent 5545bc8 commit 05d78cf

File tree

7 files changed

+45
-9
lines changed

7 files changed

+45
-9
lines changed

.github/recipe/meta.yaml.in

+10-6
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
{% set name = "robotframework-jupyterlibrary" %}
21
{% set version = "REPLACE_THIS_VERSION" %}
32

43
package:
5-
name: {{ name }}
4+
name: robotframework-jupyterlibrary
65
version: {{ version }}
76

87
source:
8+
# url: https://pypi.io/packages/source/r/robotframework-jupyterlibrary/robotframework_jupyterlibrary-{{ version }}.tar.gz
99
url: REPLACE_THIS_PATH
1010
sha256: REPLACE_THIS_SHA256
1111

@@ -33,11 +33,15 @@ test:
3333
- pip check
3434

3535
about:
36-
home: https://github.com/robots-from-jupyter/{{ name }}
36+
home: https://github.com/robots-from-jupyter/robotframework-jupyterlibrary
3737
license: BSD-3-Clause
3838
license_family: BSD
3939
license_file: LICENSE
4040
summary: A Robot Framework library for testing Jupyter end-user applications and extensions
41-
doc_url: https://{{ name }}.readthedocs.io
42-
dev_url: https://github.com/robots-from-jupyter/{{ name }}
43-
doc_source_url: https://github.com/robots-from-jupyter/{{ name }}/tree/main/docs
41+
doc_url: https://robotframework-jupyterlibrary.readthedocs.io
42+
doc_source_url: https://github.com/robots-from-jupyter/robotframework-jupyterlibrary/tree/v{{ version }}/docs
43+
44+
extra:
45+
recipe-maintainers:
46+
- martinRenou
47+
- bollwyvl

_scripts/project.py

+9
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import os
44
import platform
55
import shutil
6+
import subprocess
67
import sys
78
from pathlib import Path
89

@@ -361,3 +362,11 @@ def get_ok_actions(p: Path):
361362
lambda: p.unlink() if p.exists() else None,
362363
lambda: [p.parent.mkdir(exist_ok=True, parents=True), p.touch(), None][-1],
363364
]
365+
366+
367+
def get_source_date_epoch():
368+
"""Get the SOURCE_DATE_EPOCH from git."""
369+
return subprocess.check_output(
370+
["git", "log", "-1", "--format=%ct"],
371+
encoding="utf-8",
372+
).strip()

docs/HISTORY.ipynb

+16
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,22 @@
77
"# HISTORY"
88
]
99
},
10+
{
11+
"cell_type": "markdown",
12+
"metadata": {},
13+
"source": [
14+
"## 0.5.0a1\n",
15+
"\n",
16+
"| Products under test | Versions |\n",
17+
"|-----------------------------|-----------------------|\n",
18+
"| Python | `3.8.16`<br/>`3.11.3` |\n",
19+
"| CodeMirror | `5`<br/>`6` |\n",
20+
"| Robot Framework | `5.0.1`<br/>`6.0.2` |\n",
21+
"| Jupyter Notebook | `6.5.4`<br/>`7.0.0b3` |\n",
22+
"| JupyterLab | `3.6.4`<br/>`4.0.1` |\n",
23+
"| Jupyter Server | `2.6.0` |"
24+
]
25+
},
1026
{
1127
"cell_type": "markdown",
1228
"metadata": {},

dodo.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,15 @@ def task_build():
6060
env_lock = P.CONDA_LISTS[env]
6161
run_in = P.RUN_IN[env]
6262

63+
def _flit_build():
64+
env = dict(os.environ, SOURCE_DATE_EPOCH=P.get_source_date_epoch())
65+
rc = subprocess.call([*run_in, "flit", "--debug", "build"], env=env)
66+
return rc == 0
67+
6368
yield {
6469
"name": "pypi",
6570
"doc": "build the pypi sdist/wheel",
66-
"actions": [[*run_in, "flit", "build"]],
71+
"actions": [_flit_build],
6772
"targets": [P.SDIST, P.WHEEL],
6873
"file_dep": [*P.PY_SRC, *P.ROBOT_SRC, *P.SETUP_CRUFT, env_lock],
6974
}

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ name = "JupyterLibrary"
77

88
[project]
99
name = "robotframework-jupyterlibrary"
10-
version = "0.5.0a0"
10+
version = "0.5.0a1"
1111
description = "A Robot Framework library for automating (testing of) Jupyter end-user applications and extensions."
1212
readme = "README.md"
1313
authors = [{name = "JupyterLibrary contributors", email = "[email protected]"}]

src/JupyterLibrary/clients/notebook/Selectors.resource

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ ${JNB CSS CELL} ${JLAB CSS CELL}
1414
${JNB CSS ACCEPT} ${JLAB CSS MOD ACCEPT}
1515

1616
# css selectors
17+
${JNB CSS TREE} .jp-DirListing
1718
${JNB CSS TREE LIST} .jp-DirListing-content
1819
${JNB CSS TREE LIST ITEM} ${JNB CSS TREE LIST} .jp-DirListing-item
1920
${JNB CSS TREE NEW MENU} ${LM CSS MENU}

src/JupyterLibrary/clients/notebook/Tree.resource

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ Open Notebook
1818
${final_url} = Set Variable If "${url}" ${url} ${nbserver_url}tree?token=${token}
1919
Open Browser url=${final_url} browser=${browser} &{configuration}
2020
Update Globals For JupyterLab 4
21-
Wait Until Element Is Visible css:${JNB CSS TREE LIST}
21+
Wait Until Element Is Visible css:${JNB CSS TREE}
22+
Wait Until Element Is Visible css:${JNB CSS TREE LIST} timeout=10s
2223

2324
Launch A New Notebook
2425
[Documentation] Use the Jupyter Notebook tree to launch a Notebook with the

0 commit comments

Comments
 (0)