Non-transferable items #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashWarlock
reviewed
May 31, 2022
bmacer
reviewed
May 31, 2022
bmacer
approved these changes
May 31, 2022
Contributor
bmacer
left a comment
bmacer
left a comment
There was a problem hiding this comment.
Consider changing check_is_transferable to accept &nft but looks good otherwise or if decision is to keep if with bool
Contributor
|
Looks good. I think we should add this as a disclaimer or a warning for any parachain looking to integrate the RMRK pallet into their runtime that they should disable Uniques Calls to avoid the scenario below. In the future, when a RMRK NFT is teleported to another chain with Uniques Calls enabled there could be a situation where a non-transferable could be sent to another account. This could be an issue in the future if that scenario were to happen. |
HashWarlock
approved these changes
May 31, 2022
Contributor
Author
|
Thank you, made a new issue to address such disclaimer / warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141