Ids contradiction

[mrshiposha]

Resource Id

There are different representations of the Resource Id.

1) u32 representation

One is in the rmrk-traits:

rmrk-substrate/traits/src/lib.rs

Line 23 in 0bcc42a

pub type ResourceId = u32;

It is used in NextResourceId storage:

rmrk-substrate/pallets/rmrk-core/src/lib.rs

Line 92 in 0bcc42a

pub type NextResourceId<T: Config> = StorageValue<_, ResourceId, ValueQuery>;

And it is used in the priorities:

rmrk-substrate/pallets/rmrk-core/src/lib.rs

Lines 113 to 118 in 0bcc42a

	pub type Priorities<T: Config> = StorageNMap<
	_,
	(
	NMapKey<Blake2_128Concat, CollectionId>,
	NMapKey<Blake2_128Concat, NftId>,
	NMapKey<Blake2_128Concat, ResourceId>,

---

2) string representation

Another representation of the resource Id is BoundedVec<u8, ResourceSymbolLimit>:

rmrk-substrate/pallets/rmrk-core/src/lib.rs

Lines 31 to 35 in 0bcc42a

	pub type ResourceOf<T, R, P> = ResourceInfo::<
	BoundedVec<u8, R>,
	BoundedVec<u8, <T as pallet_uniques::Config>::StringLimit>,
	BoundedVec<PartId, P>
	>;

Unused resource Id generation

The NextResourceId used only in get_next_resource_id function which is never used:

rmrk-substrate/pallets/rmrk-core/src/functions.rs

Lines 657 to 663 in 0bcc42a

	pub fn get_next_resource_id() -> Result<ResourceId, Error<T>> {
	NextResourceId::<T>::try_mutate(|id| {
	let current_id = *id;
	*id = id.checked_add(1).ok_or(Error::<T>::NoAvailableCollectionId)?;
	Ok(current_id)
	})
	}

Part Id

Unused Id generation. The Id is taken from the create_base extrinsic input.
Storage NextPartId and the function get_next_part_id are unused.

Observation about IDs

In the RMRK spec, parts and resources obtain their IDs from some external generator (like the nanoid).
It seems it is intended to generate IDs internally in the rmrk-substrate (as far as I can understand from the code).
But ids are still expected from the inputs.

[HashWarlock]

@bmacer can you clarify on this? I'm running into some problems as well with assigning a Resource to an NFT from the mint. The current process seems to only allow for me to add metadata & I cannot add the resource without the new owner that minted the NFT needing to accept the resource.

Functionality that I'm missing:

1. Generate a Resource ID without having to define it in a parameter

• Also, there is not any logic in place to ensure that a Resource ID can be used multiple times. This will result in the previous resource ID to be overwritten. Though I do not see this a major problem since it is stored in a StorageNMap. A proper generator that can generate a BoundedVec Resource ID could help.

2. Minting a NFT with Resource info included to ensure the NFT has a resource to display after mint.

[bmacer]

The auto-generated resource id is the functionality we should have. My previous belief was that it would be more convenient to assign a resource Id (in fact all ids would be my preference) but Bruno alerted to the priority of minimal space consumption on-chain.

I'll work on fixing this asap.