Skip to content

option not to copy files #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hydrargyrum opened this issue Apr 6, 2025 · 1 comment · Fixed by #13
Closed

option not to copy files #8

hydrargyrum opened this issue Apr 6, 2025 · 1 comment · Fixed by #13

Comments

@hydrargyrum
Copy link
Contributor

Current Situation

I have this config

[[tool.hatch.build.hooks.build-scripts.scripts]]
artifacts = ["pjy.1"]
commands = [
    "asciidoctor -b manpage pjy.adoc",
]

So I'm building pjy.1 file into the repo root dir. Then for some reason hatch-build-scripts tries to copy the built file $/pjy.1 into out dir $/pjy.1, which obviously fails:

  File "/tmp/1000/build-env-pvakc__9/lib/python3.13/site-packages/hatch_build_scripts/plugin.py", line 60, in initialize
    shutil.copyfile(src_file, out_file)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/shutil.py", line 240, in copyfile
    raise SameFileError("{!r} and {!r} are the same file".format(src, dst))
shutil.SameFileError: PosixPath('/tmp/1000/release-pjy.fbWHAl/pjy.1') and PosixPath('/tmp/1000/release-pjy.fbWHAl/pjy.1') are the same file

ERROR Backend subprocess exited when trying to invoke build_sdist

Proposed Actions

Either

  • don't call copyfile if the source is the same as the destination
  • or propose an option not to copy artifacts
hydrargyrum added a commit to hydrargyrum/hatch-build-scripts that referenced this issue Apr 6, 2025
@hydrargyrum
plugin: don't try to copy file onto itself
68114ad 
If the command generates the artifact in the right place, there's no
need to copy it to out directory

Closes rmorshea#8
@hydrargyrum hydrargyrum mentioned this issue Apr 6, 2025
Closed
@johnandersen777
Copy link
Contributor

johnandersen777 commented Apr 20, 2025 •
edited
Loading

Running into this same issue, for example:

[[tool.hatch.build.hooks.build-scripts.scripts]]
out_dir = "src/sshai"
work_dir = "src/sshai/compiled"
commands = [
    "CGO_ENABLED=0 go build -tags netgo -o agi_sshd agi_sshd.go",
]
artifacts = [
    "agi_sshd",
]
$ python -m tarfile -l dist/sshai-0.0.1.tar.gz | grep agi_sshd
sshai-0.0.1/src/sshai/agi_sshd 
sshai-0.0.1/src/sshai/compiled/agi_sshd 
sshai-0.0.1/src/sshai/compiled/agi_sshd.go

Obviously we don't want both compiled artifacts in the dist.

Setting out_dir to the same as work_dir produces the same shutil error above.

The workaround I have is to put stuff in another directory and exclude the artifact that ends up there from the dist

[tool.hatch.build]
exclude = [
    "src/sshd/agi_sshd",
]

rmorshea pushed a commit that referenced this issue May 29, 2025
@hydrargyrum @rmorshea
plugin: don't try to copy file onto itself
ce5a87c 
If the command generates the artifact in the right place, there's no
need to copy it to out directory

Closes #8
@rmorshea rmorshea mentioned this issue May 29, 2025
Merged
rmorshea added a commit that referenced this issue May 29, 2025
@rmorshea @hydrargyrum
plugin: don't try to copy file onto itself (#13)
79c2c8a 
If the command generates the artifact in the right place, there's no
need to copy it to out directory

Closes #8

Co-authored-by: hydrargyrum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hydrargyrum @johnandersen777