test(Trusted_Peers_Add_Missing_Peer_ID): is evil

richardschneider · richardschneider · commit 3fe8a56a31d9 · 2017-11-12T10:44:37.000+13:00
js-ipfs does NOT check IPFS addresses. And this bad addr eventually breaks the server. See ipfs/js-ipfs#1066
diff --git a/test/TrustedPeersTest.cs b/test/TrustedPeersTest.cs
@@ -31,13 +31,18 @@ public void Trusted_Peers_Add_Remove()
             Assert.IsFalse(ipfs.TrustedPeers.Contains(newTrustedPeer));
         }
 
+        // js-ipfs does NOT check IPFS addresses.
+        // And this bad addr eventually breaks the server.
+        // https://github.com/ipfs/js-ipfs/issues/1066
+#if false
         [TestMethod]
         public void Trusted_Peers_Add_Missing_Peer_ID()
         {
             var missingPeerId = new MultiAddress("/ip4/25.196.147.100/tcp/4001");
             var ipfs = TestFixture.Ipfs;
             ExceptionAssert.Throws<Exception>(() => ipfs.TrustedPeers.Add(missingPeerId), "invalid IPFS address");
         }
+#endif
 
         [TestMethod]
         public void Trusted_Peers_Clear()

Original file line number	Diff line number	Diff line change
`@@ -31,13 +31,18 @@ public void Trusted_Peers_Add_Remove()`
`31`	`31`	`Assert.IsFalse(ipfs.TrustedPeers.Contains(newTrustedPeer));`
`32`	`32`	`}`
`33`	`33`
	`34`	`+ // js-ipfs does NOT check IPFS addresses.`
	`35`	`+ // And this bad addr eventually breaks the server.`
	`36`	`+ // https://github.com/ipfs/js-ipfs/issues/1066`
	`37`	`+#if false`
`34`	`38`	`[TestMethod]`
`35`	`39`	`public void Trusted_Peers_Add_Missing_Peer_ID()`
`36`	`40`	`{`
`37`	`41`	`var missingPeerId = new MultiAddress("/ip4/25.196.147.100/tcp/4001");`
`38`	`42`	`var ipfs = TestFixture.Ipfs;`
`39`	`43`	`ExceptionAssert.Throws<Exception>(() => ipfs.TrustedPeers.Add(missingPeerId), "invalid IPFS address");`
`40`	`44`	`}`
	`45`	`+#endif`
`41`	`46`
`42`	`47`	`[TestMethod]`
`43`	`48`	`public void Trusted_Peers_Clear()`