Skip to content

Commit beed168

Browse files
committed
Filter dependencies from partest and scalacheck.
I previously messed this up in a24e7fa, which caused partest classpath again to include multiple version of scala-library and friends. We should really automate enforcing uniqueness of packages.
1 parent d2cee3a commit beed168

File tree

1 file changed

+25
-3
lines changed

1 file changed

+25
-3
lines changed

build.xml

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,13 @@ TODO:
286286
-->
287287
<!-- <artifact:remoteRepository refid="extra-repo"/> -->
288288
<dependency groupId="org.scala-lang.modules" artifactId="scala-partest_${scala.binary.version}" version="${partest.version.number}" />
289-
<dependency groupId="org.scalacheck" artifactId="scalacheck_${scala.binary.version}" version="${scalacheck.version.number}" />
290289
</artifact:dependencies>
291290
<copy-deps project="partest"/>
292291

292+
<artifact:dependencies pathId="scalacheck.classpath" filesetId="scalacheck.fileset" versionsId="scalacheck.versions">
293+
<dependency groupId="org.scalacheck" artifactId="scalacheck_${scala.binary.version}" version="${scalacheck.version.number}" />
294+
</artifact:dependencies>
295+
293296
<artifact:dependencies pathId="repl.deps.classpath" filesetId="repl.fileset" versionsId="repl.deps.versions">
294297
<dependency groupId="jline" artifactId="jline" version="${jline.version}"/>
295298
</artifact:dependencies>
@@ -894,11 +897,30 @@ TODO:
894897
<pathelement location="${actors.jar}"/>
895898

896899
<!-- partest's dependencies, which marks most of its dependencies as provided,
900+
(but not scala-library, so we filter that one out...)
897901
so we provide them: scala-[library/reflect/compiler], scalap built here,
898902
scala-xml, scala-parser-combinators via external-modules-nocore,
899903
scalacheck as part of `partest.classpath` -->
900-
<path refid="partest.classpath"/>
901-
<path refid="external-modules-nocore"/> <!-- xml, parsers -->
904+
<restrict>
905+
<path refid="partest.classpath"/>
906+
<rsel:not><rsel:or>
907+
<rsel:name name="scala-library*.jar"/>
908+
</rsel:or></rsel:not>
909+
</restrict>
910+
<pathelement location="${scala-xml}"/>
911+
<pathelement location="${scala-parser-combinators}"/>
912+
913+
<restrict>
914+
<path refid="scalacheck.classpath"/>
915+
<rsel:not><rsel:or>
916+
<rsel:name name="scala-library*.jar"/>
917+
<rsel:name name="scala-compiler*.jar"/>
918+
<rsel:name name="scala-reflect*.jar"/>
919+
<rsel:name name="scala-actors*.jar"/>
920+
<rsel:name name="scala-parser-combinators*.jar"/>
921+
<rsel:name name="scala-xml*.jar"/>
922+
</rsel:or></rsel:not>
923+
</restrict>
902924

903925
<!-- partest classes specific to the core compiler build -->
904926
<pathelement location="${partest-extras.jar}"/>

0 commit comments

Comments
 (0)