Skip to content

Cyclic errors and others don't show up in .compiler.log #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenglou opened this issue May 5, 2021 · 7 comments
Closed

Cyclic errors and others don't show up in .compiler.log #5106

chenglou opened this issue May 5, 2021 · 7 comments

Comments

@chenglou
Copy link
Member

chenglou commented May 5, 2021

The errors outside of the typical pipeline (cyclic deps, ppx, etc) don't show in .compiler.log.

Just filing this, though I'm not sure we should put more stress onto .compiler.log

@bobzhang
Copy link
Member

bobzhang commented May 6, 2021

can you provide more concrete information so that it can be addressed in a batch style. This is a bit vague

@cristianoc
Copy link
Collaborator

See here:
rescript-lang/rescript-vscode#212

I think that breaks the contract of what compiler.log should contain, in terms of shape of messages.

@chenglou
Copy link
Member Author

chenglou commented May 6, 2021

Sorry I think this is my mistake. I presumed the compiler log always indented an error two spaces. This one isn’t, so the mini parser skipped it

@bobzhang
Copy link
Member

@chenglou is this still relevant?

@bobzhang
Copy link
Member

ping @chenglou

@cristianoc
Copy link
Collaborator

Just revisited this. For context: self-cycle error goes to compiler.log, but cycle of size 2 or more the log is empty. Cannot be solved in the editor without a compiler fix.

@cristianoc
Copy link
Collaborator

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants