Ensure version bump using Yarn constraints

Author: cometkim

.github/workflows/ci.yml

@@ -338,7 +338,7 @@ jobs:
         run: git diff --exit-code lib/js lib/es6
 
       - name: Version Check
-        run: ./scripts/prebuilt.js
+        run: yarn constraints
 
       - name: Run tests
         run: node scripts/test.js -all

CONTRIBUTING.md

@@ -388,8 +388,8 @@ To build a new version and release it on NPM, follow these steps:
    - `npm dist-tag add @rescript/std@<version> <tag>`
 1. Create a release entry for the version tag on the [Github Releases page](https://github.com/rescript-lang/rescript-compiler/releases), copying the changes from `CHANGELOG.md`.
 1. Create a PR with the following changes to prepare for development of the next version:
-   - Increment the version number in `package.json` for the next version.
-   - Run `node scripts/setVersion.js` to take that version number over into other files.
+   - Increment the `EXPECTED_VERSION` number in `yarn.config.cjs` for the next version.
+   - Run `yarn constraints --fix` to take that version number over into other files.
    - Update `CHANGELOG.md` and add an entry for the next version, e.g., "10.0.0-beta.2 (Unreleased)"
 1. Coordinate any forum/blog posts with [@ryyppy](https://github.com/ryyppy).
 

Makefile

@@ -59,11 +59,9 @@ reanalyze:
 
 lib-bsb:
 	./scripts/buildRuntime.sh
-	./scripts/prebuilt.js
 
 lib:
 	./scripts/buildRuntimeRewatch.sh
-	./scripts/prebuilt.js
 
 artifacts: lib
 	./scripts/npmPack.js --updateArtifactList

package.json

@@ -84,10 +84,9 @@
   "devDependencies": {
     "@biomejs/biome": "1.9.4",
     "@types/node": "^20.14.9",
-    "@types/semver": "^7.5.8",
+    "@yarnpkg/types": "^4.0.1",
     "mocha": "10.8.2",
     "nyc": "15.0.0",
-    "semver": "7.6.2",
     "typescript": "5.8.2"
   },
   "workspaces": [

scripts/prebuilt.js

@@ -1,4 +1,4 @@
 {
-  "name": "@rescript/react",
+  "name": "@tests/rescript-react",
   "private": true
 }

scripts/setVersion.js

@@ -19,6 +19,7 @@
     "packages/**",
     "tests/**/input.js",
     ".github/workflows/*.js",
+    "yarn.config.cjs",
     "package.json"
   ],
   "exclude": ["*.res.js", "*.res.mjs"]

tests/dependencies/rescript-react/package.json

@@ -0,0 +1,51 @@
+// @ts-check
+
+/**
+ * @import { Yarn } from "@yarnpkg/types"
+ */
+
+const fs = require("node:fs/promises");
+const { defineConfig } = require("@yarnpkg/types");
+
+const { compilerVersionFile } = require("#dev/paths");
+
+/**
+ * @param {Yarn.Constraints.Context} ctx
+ */
+async function enforceCompilerVersion({ Yarn }) {
+  const EXPECTED_VERSION = "12.0.0-alpha.13";
+
+  for (const workspace of Yarn.workspaces()) {
+    const { ident } = workspace.pkg;
+    if (ident === "rescript" || ident.startsWith("@rescript/")) {
+      workspace.set("version", EXPECTED_VERSION);
+    }
+  }
+
+  const versionFile = await fs.readFile(compilerVersionFile, "utf8");
+  const versionPattern = /^let version = "(?<version>[^"]+)"$/m;
+
+  if (process.argv.includes("--fix")) {
+    await fs.writeFile(
+      compilerVersionFile,
+      versionFile.replace(
+        versionPattern,
+        `let version = "${EXPECTED_VERSION}"`,
+      ),
+    );
+  } else {
+    const versionMatch = versionFile.match(versionPattern);
+    const foundVersion = versionMatch?.groups?.version;
+    if (foundVersion !== EXPECTED_VERSION) {
+      Yarn.workspace().error(
+        `compiler/common/bs_version.ml file need to be fiexed; expected ${EXPECTED_VERSION}, found ${foundVersion}.`,
+      );
+    }
+  }
+}
+
+module.exports = defineConfig({
+  async constraints(ctx) {
+    await enforceCompilerVersion(ctx);
+  },
+});

tsconfig.json

@@ -440,12 +440,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@rescript/react@workspace:tests/dependencies/rescript-react":
-  version: 0.0.0-use.local
-  resolution: "@rescript/react@workspace:tests/dependencies/rescript-react"
-  languageName: unknown
-  linkType: soft
-
 "@rescript/std@workspace:packages/std":
   version: 0.0.0-use.local
   resolution: "@rescript/std@workspace:packages/std"
@@ -689,6 +683,12 @@ __metadata:
   languageName: unknown
   linkType: soft
 
+"@tests/rescript-react@workspace:tests/dependencies/rescript-react":
+  version: 0.0.0-use.local
+  resolution: "@tests/rescript-react@workspace:tests/dependencies/rescript-react"
+  languageName: unknown
+  linkType: soft
+
 "@tests/tools@workspace:tests/tools_tests":
   version: 0.0.0-use.local
   resolution: "@tests/tools@workspace:tests/tools_tests"
@@ -747,10 +747,12 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/semver@npm:^7.5.8":
-  version: 7.5.8
-  resolution: "@types/semver@npm:7.5.8"
-  checksum: 10c0/8663ff927234d1c5fcc04b33062cb2b9fcfbe0f5f351ed26c4d1e1581657deebd506b41ff7fdf89e787e3d33ce05854bc01686379b89e9c49b564c4cfa988efa
+"@yarnpkg/types@npm:^4.0.1":
+  version: 4.0.1
+  resolution: "@yarnpkg/types@npm:4.0.1"
+  dependencies:
+    tslib: "npm:^2.4.0"
+  checksum: 10c0/90226789475680ba599833571dd76c0718dd5b4c5022481263ef309d6a628f6246671cd6ca86e49c966ddefa7aca6ccef82240dc1476d2cea702ea5bee2a6b72
   languageName: node
   linkType: hard
 
@@ -2481,10 +2483,9 @@ __metadata:
     "@rescript/linux-x64": "workspace:packages/@rescript/linux-x64"
     "@rescript/win32-x64": "workspace:packages/@rescript/win32-x64"
     "@types/node": "npm:^20.14.9"
-    "@types/semver": "npm:^7.5.8"
+    "@yarnpkg/types": "npm:^4.0.1"
     mocha: "npm:10.8.2"
     nyc: "npm:15.0.0"
-    semver: "npm:7.6.2"
     typescript: "npm:5.8.2"
   dependenciesMeta:
     "@rescript/darwin-arm64":
@@ -2666,15 +2667,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"semver@npm:7.6.2":
-  version: 7.6.2
-  resolution: "semver@npm:7.6.2"
-  bin:
-    semver: bin/semver.js
-  checksum: 10c0/97d3441e97ace8be4b1976433d1c32658f6afaff09f143e52c593bae7eef33de19e3e369c88bd985ce1042c6f441c80c6803078d1de2a9988080b66684cbb30c
-  languageName: node
-  linkType: hard
-
 "semver@npm:^6.0.0, semver@npm:^6.3.0, semver@npm:^6.3.1":
   version: 6.3.1
   resolution: "semver@npm:6.3.1"
@@ -2924,6 +2916,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"tslib@npm:^2.4.0":
+  version: 2.8.1
+  resolution: "tslib@npm:2.8.1"
+  checksum: 10c0/9c4759110a19c53f992d9aae23aac5ced636e99887b51b9e61def52611732872ff7668757d4e4c61f19691e36f4da981cd9485e869b4a7408d689f6bf1f14e62
+  languageName: node
+  linkType: hard
+
 "type-fest@npm:^0.8.0":
   version: 0.8.1
   resolution: "type-fest@npm:0.8.1"