wire up constructor docstrings (even though the parser doesnt handle docstrings on constructors yet)

Author: zth

analysis/src/CompletionBackEnd.ml

@@ -598,7 +598,7 @@ let completionsForExportedConstructors ~(env : QueryEnv.t) ~prefix ~exact
                  if not (Hashtbl.mem namesUsed name) then
                    let () = Hashtbl.add namesUsed name () in
                    Some
-                     (Completion.create ~name ~env
+                     (Completion.create ~name ~env ~docstring:c.docstring
                         ~kind:
                           (Completion.Constructor
                              (c, t.item.decl |> Shared.declToString t.name.txt))

analysis/src/Hover.ml

@@ -241,7 +241,7 @@ let newHover ~full:{file; package} ~supportsMarkdownLinks locItem =
         | `Declared ->
           let typeString, docstring = t |> fromType ~docstring in
           typeString :: docstring
-        | `Constructor {cname = {txt}; args} ->
+        | `Constructor {cname = {txt}; args; docstring} ->
           let typeString, docstring = t |> fromType ~docstring in
           let argsString =
             match args with

analysis/src/ProcessCmt.ml

@@ -76,6 +76,13 @@ let rec forTypeSignatureItem ~(env : SharedTypes.Env.t) ~(exported : Exported.t)
                                | Cstr_record _ -> []);
                              res = cd_res;
                              typeDecl = (name, decl);
+                             docstring =
+                               (match
+                                  ProcessAttributes.findDocAttribute
+                                    cd_attributes
+                                with
+                               | None -> []
+                               | Some docstring -> [docstring]);
                            }
                          in
                          let declared =
@@ -207,6 +214,12 @@ let forTypeDeclaration ~env ~(exported : Exported.t)
                              | None -> None
                              | Some t -> Some t.ctyp_type);
                            typeDecl = (name.txt, typ_type);
+                           docstring =
+                             (match
+                                ProcessAttributes.findDocAttribute cd_attributes
+                              with
+                             | None -> []
+                             | Some docstring -> [docstring]);
                          }
                        in
                        let declared =

analysis/src/References.ml

@@ -169,7 +169,8 @@ let definedForLoc ~file ~package locKind =
     | Constructor name -> (
       match getConstructor file stamp name with
       | None -> None
-      | Some constructor -> Some ([], `Constructor constructor))
+      | Some constructor ->
+        Some (constructor.docstring, `Constructor constructor))
     | Field name ->
       Some
         ( (match getField file stamp name with

analysis/src/SharedTypes.ml

@@ -39,6 +39,7 @@ module Constructor = struct
     args: (Types.type_expr * Location.t) list;
     res: Types.type_expr option;
     typeDecl: string * Types.type_declaration;
+    docstring: string list;
   }
 end