complete bools as arguments

Author: zth

analysis/src/CompletionBackEnd.ml

@@ -1531,6 +1531,27 @@ let rec extractType ~env ~package (t : Types.type_expr) =
     Some (Polyvariant (env, constructors))
   | Ttuple expressions -> Some (Tuple (env, expressions))
   | _ -> None
+
+let completeTypedValue t ~env ~full ~prefix =
+  match t |> extractType ~env ~package:full.package with
+  | Some (Tbool env) ->
+    let items =
+      [
+        Completion.create ~name:"true"
+          ~kind:(Label (t |> Shared.typeToString))
+          ~env;
+        Completion.create ~name:"false"
+          ~kind:(Label (t |> Shared.typeToString))
+          ~env;
+      ]
+    in
+    if prefix = "" then items
+    else
+      items
+      |> List.filter (fun (item : Completion.t) ->
+             Utils.startsWith item.name prefix)
+  | _ -> []
+
 let processCompletable ~debug ~full ~scope ~env ~pos ~forHover
     (completable : Completable.t) =
   let package = full.package in
@@ -1893,7 +1914,23 @@ Note: The `@react.component` decorator requires the react-jsx config to be set i
            in
            (dec2, doc))
     |> List.map mkDecorator
-  | Cargument _ -> []
+  | Cargument {contextPath; argumentLabel; prefix} -> (
+    let labels =
+      match
+        contextPath
+        |> getCompletionsForContextPath ~full ~opens ~rawOpens ~allFiles ~pos
+             ~env ~exact:true ~scope
+        |> completionsGetTypeEnv
+      with
+      | Some (typ, _env) -> typ |> getArgs ~full ~env
+      | None -> []
+    in
+    let targetLabel =
+      labels |> List.find_opt (fun (label, _) -> label = argumentLabel)
+    in
+    match targetLabel with
+    | None -> []
+    | Some (_, typ) -> typ |> completeTypedValue ~env ~full ~prefix)
   | CnamedArg (cp, prefix, identsSeen) ->
     let labels =
       match
@@ -1906,6 +1943,7 @@ Note: The `@react.component` decorator requires the react-jsx config to be set i
         if debug then
           Printf.printf "Found type for function %s\n"
             (typ |> Shared.typeToString);
+
         typ |> getArgs ~full ~env
         |> List.filter_map (fun arg ->
                match arg with

analysis/tests/src/CompletionFunctionArguments.res

@@ -24,5 +24,5 @@ let someOtherFn = (includeName, age) => {
   "Hello" ++ (includeName ? " Some Name" : "") ++ ", you are age " ++ Belt.Int.toString(age)
 }
 
-// let _ = someOtherFn(t)
+// let _ = someOtherFn(f)
 //                      ^com

analysis/tests/src/expected/CompletionFunctionArguments.res.txt

@@ -2,13 +2,31 @@ Complete src/CompletionFunctionArguments.res 8:24
 posCursor:[8:24] posNoWhite:[8:23] Found expr:[8:11->8:25]
 Pexp_apply ...[8:11->8:17] (~isOn8:19->8:23=...__ghost__[0:-1->0:-1])
 Completable: Value[someFn](~isOn)
-[]
+[{
+    "label": "true",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }, {
+    "label": "false",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }]
 
 Complete src/CompletionFunctionArguments.res 11:25
 posCursor:[11:25] posNoWhite:[11:24] Found expr:[11:11->11:26]
 Pexp_apply ...[11:11->11:17] (~isOn11:19->11:23=...[11:24->11:25])
 Completable: Value[someFn](~isOn=t)
-[]
+[{
+    "label": "true",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }]
 
 Complete src/CompletionFunctionArguments.res 16:27
 posCursor:[16:27] posNoWhite:[16:26] Found expr:[14:8->20:1]
@@ -18,11 +36,29 @@ posCursor:[16:27] posNoWhite:[16:26] Found expr:[16:7->16:28]
 posCursor:[16:27] posNoWhite:[16:26] Found expr:[16:14->16:28]
 Pexp_apply ...[16:14->16:20] (~isOn16:22->16:26=...__ghost__[0:-1->0:-1])
 Completable: Value[someFn](~isOn)
-[]
+[{
+    "label": "true",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }, {
+    "label": "false",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }]
 
 Complete src/CompletionFunctionArguments.res 26:24
 posCursor:[26:24] posNoWhite:[26:23] Found expr:[26:11->26:25]
 Pexp_apply ...[26:11->26:22] (...[26:23->26:24])
-Completable: Value[someOtherFn]($0=t)
-[]
+Completable: Value[someOtherFn]($0=f)
+[{
+    "label": "false",
+    "kind": 4,
+    "tags": [],
+    "detail": "bool",
+    "documentation": null
+  }]