docgen: polish (#825)

Author: aspeddro

analysis/src/DocExtraction.ml

@@ -237,7 +237,7 @@ let extractDocs ~path ~debug =
     FindFiles.isImplementation path = false
     && FindFiles.isInterface path = false
   then (
-    Printf.printf "error: failed to read %s, expected an .res or .resi file\n"
+    Printf.eprintf "error: failed to read %s, expected an .res or .resi file\n"
       path;
     exit 1);
   let path =
@@ -256,7 +256,7 @@ let extractDocs ~path ~debug =
   in
   match Cmt.loadFullCmtFromPath ~path with
   | None ->
-    Printf.printf
+    Printf.eprintf
       "error: failed to generate doc for %s, try to build the project\n" path;
     exit 1
   | Some full ->

client/src/commands.ts

@@ -6,7 +6,6 @@ import {
 } from "./commands/code_analysis";
 
 export { createInterface } from "./commands/create_interface";
-export { extractDocs } from "./commands/extract_docs";
 export { openCompiled } from "./commands/open_compiled";
 export { switchImplIntf } from "./commands/switch_impl_intf";
 

client/src/commands/extract_docs.ts

@@ -201,9 +201,6 @@ export function activate(context: ExtensionContext) {
     customCommands.openCompiled(client);
   });
 
-  commands.registerCommand("rescript-vscode.extract_docs", () => {
-    customCommands.extractDocs(client);
-  });
 
   commands.registerCommand(
     "rescript-vscode.go_to_location",

client/src/extension.ts

@@ -49,10 +49,6 @@
 				"command": "rescript-vscode.create_interface",
 				"title": "ReScript: Create an interface file for this implementation file"
 			},
-			{
-				"command": "rescript-vscode.extract_docs",
-				"title": "ReScript: Extract documentation as JSON for file."
-			},
 			{
 				"command": "rescript-vscode.open_compiled",
 				"category": "ReScript",

package.json

@@ -152,11 +152,6 @@ let openCompiledFileRequest = new v.RequestType<
   void
 >("textDocument/openCompiled");
 
-let extractDocsRequest = new v.RequestType<
-  p.TextDocumentIdentifier,
-  p.TextDocumentIdentifier,
-  void
->("textDocument/extractDocs");
 
 let getCurrentCompilerDiagnosticsForFile = (
   fileUri: string
@@ -971,24 +966,6 @@ function createInterface(msg: p.RequestMessage): p.Message {
   }
 }
 
-function extractDocs(msg: p.RequestMessage): p.Message {
-  let params = msg.params as p.TextDocumentIdentifier;
-  let filePath = fileURLToPath(params.uri);
-
-  let response = utils.runAnalysisCommand(
-    filePath,
-    ["extractDocs", filePath],
-    msg
-  );
-
-  let res: p.ResponseMessage = {
-    jsonrpc: c.jsonrpcVersion,
-    id: msg.id,
-    result: response.result,
-  };
-  return res;
-}
-
 function openCompiledFile(msg: p.RequestMessage): p.Message {
   let params = msg.params as p.TextDocumentIdentifier;
   let filePath = fileURLToPath(params.uri);
@@ -1254,8 +1231,6 @@ function onMessage(msg: p.Message) {
       send(createInterface(msg));
     } else if (msg.method === openCompiledFileRequest.method) {
       send(openCompiledFile(msg));
-    } else if (msg.method === extractDocsRequest.method) {
-      send(extractDocs(msg));
     } else if (msg.method === p.InlayHintRequest.method) {
       let params = msg.params as InlayHintParams;
       let extName = path.extname(params.textDocument.uri);