Adapt ninja config to use react ppx from upstream syntax submodule

[jchavarri]

Part 2 after rescript-lang/syntax#124 was merged.

Syncs with latest syntax commit.

[jchavarri]

cc @rickyvetter @IwanKaramazow

[jchavarri]

There's something in the test that is failing. It seems there's some part that tries to build js_refmt_compiler for testing (?) but it can't find the module Reactjs_jsx_ppx_v3 that is now part of syntax:

> [email protected] test /home/circleci/git/bucklescript
> node scripts/ciTest.js  -all

/home/circleci/git/bucklescript/ocaml/VERSION is used in version detection
File "j.ml", line 323, characters 2-26:
Warning 30: the label comment is defined in both types expression and statement.
File "j.ml", line 337, characters 2-27:
Warning 30: the label comment is defined in both types expression and case_clause.
File "ppx_entry.ml", line 32, characters 11-47:
Error: Unbound module Reactjs_jsx_ppx_v3

I guess somewhere in the linking process napkin.cmxa has to be added, but I have no idea where.

[bobzhang]

if you look at the diff of js_refmt_compiler.ml and js_compiler.ml, the React_..ppx was removed,
I think you need add include paths -I napkin here: https://github.com/rescript-lang/rescript-compiler/blob/master/jscomp/snapshot.ninja#L54 and here https://github.com/rescript-lang/rescript-compiler/blob/master/jscomp/snapshot.ninja#L50

[bobzhang]

do you have issue with git protocol?

[jchavarri]

I don't. But I didn't have ssh key configured in the terminal I was using, and updating this submodule failed.

I thought using https would remove one barrier for contributors and I saw other submodules were using it, but can roll this back if needed.

[IwanKaramazow]

Let's maybe keep it as it was, to minimize the diff.

[jchavarri]

done

[jchavarri]

Thanks @bobzhang, that seemed to fix it. @IwanKaramazow had already suggested a similar change, but I wrongly thought because there was -I syntax already, it would bring the ppx into scope, but it does not?

[bobzhang]

@jchavarri the jscomp/syntax directory is for some built-in transformations