Skip to content

bypass some types in monkey patching #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2021
Merged

bypass some types in monkey patching #4919

merged 5 commits into from
Jan 25, 2021

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Jan 25, 2021 •
edited
Loading

  • remove js_fold, js_map which is unused

  • only provide visitors for types which needs monkey patching

TODO in the future:

  • clean up the modified code, some obvious optmization can be applied
  • provide configurations per visitor instead once for all
  • sorting the order of bound identifiers

@bobzhang
bypass some types in monkey patching
4864ecf 
- remove js_iter, js_map which is unused
@bobzhang
remove unused code
466b70e 
Note take `length_object` for example, it is unknown, we can remove and inline it
@bobzhang
finish the fold generator
968a54e
@bobzhang
tweak
6b3bdc0
@bobzhang
finish the removal of all object usage
bbf93c9
@bobzhang bobzhang merged commit a4ccf25 into master Jan 25, 2021
@bobzhang bobzhang deleted the bypass branch January 25, 2021 03:54
This was referenced Mar 15, 2021
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobzhang