Finish the optimization around visitor pattern using objects #4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the object already had a late binding for methods TODO: we may do eta-expansion here to avoid the cost of currying
the semantics for open recursion with high order function is tricky let's not use it at all code like this `(fun self -> self#hi)` is very hard to reason about
bobzhang
commented
Jan 22, 2021
|
|
||
| let calculate_hard_dependencies block = | ||
| let hard_dependencies = create 17 in | ||
| (count_hard_dependencies hard_dependencies)#block block ; | ||
| let obj = (count_hard_dependencies hard_dependencies) in | ||
| obj.block obj block ; |
There was a problem hiding this comment.
this object is used only once
bobzhang
commented
Jan 22, 2021
| @@ -58,8 +57,8 @@ let flatten_map = | |||
| | {statement_desc = Exp last_one ; _} :: rest_rev | |||
| -> | |||
| S.block (Ext_list.rev_map_append rest_rev | |||
| [self#statement @@ S.exp (E.assign a last_one)] | |||
| self#statement | |||
| [self.statement self (S.exp (E.assign a last_one))] | |||
There was a problem hiding this comment.
assuming we follow the design pattern, called as self.xx self xx
This could be fused just as: statement self
bobzhang
commented
Jan 22, 2021
| | x::rest | ||
| -> | ||
| let st = self#statement x in | ||
| let block = self#block rest in |
There was a problem hiding this comment.
in theory, we can tie the knot, fix self in the definition of flatten_map object
bobzhang
commented
Jan 22, 2021
| match vd.ident_info.used_stats with | ||
| | Dead_pure | ||
| -> () | ||
| | Dead_non_pure -> | ||
| begin match vd.value with | ||
| | None -> () | ||
| | Some x -> self#expression x | ||
| | Some x -> self.expression self x | ||
| end |
There was a problem hiding this comment.
in theory, we can tie the knot here, and since mark_dead.expression is the same as super.expression, we can call super.expression directly
The downside is that if we do override super.expression, it will be wrong
bobzhang
commented
Jan 22, 2021
| @@ -48,30 +48,31 @@ let post_process_stats my_export_set (defined_idents : J.variable_declaration Ha | |||
| since in this case it can not be global? | |||
|
|
|||
| *) | |||
| let super = Js_record_iter.iter | |||
| let count_collects | |||
| (* collect used status*) | |||
| (stats : int Hash_ident.t) | |||
| (* collect all def sites *) | |||
There was a problem hiding this comment.
check if this visitor is used a lot, some micro-optimizations could be applied here
bobzhang
commented
Jan 22, 2021
bobzhang
commented
Jan 22, 2021
| begin _self.module_id _self _x0 end ) ; | ||
| exception_ident : exception_ident fn = ( (fun _self arg -> _self.ident _self arg) ) ; | ||
| for_ident : for_ident fn = ( (fun _self arg -> _self.ident _self arg) ) ; | ||
| for_direction : for_direction fn = ( unknown ) ; |
bobzhang
commented
Jan 22, 2021
| exception_ident : exception_ident fn = ( (fun _self arg -> _self.ident _self arg) ) ; | ||
| for_ident : for_ident fn = ( (fun _self arg -> _self.ident _self arg) ) ; | ||
| for_direction : for_direction fn = ( unknown ) ; | ||
| property_map : property_map fn = ( fun _self arg -> list ((fun _self (_x0,_x1) -> begin _self.expression _self _x1 end)) _self arg ) ; |
There was a problem hiding this comment.
this is actually hard to simplify -- we can create a closure using _self, but not sure if it is worth it
bobzhang
commented
Jan 22, 2021
bobzhang
commented
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.