Skip to content

Commit c48341d

Browse files
authored
Lift startViewTransition implementation to react-router-dom (#10928)
1 parent b916689 commit c48341d

File tree

9 files changed

+358
-235
lines changed

9 files changed

+358
-235
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"react-router-dom": patch
3+
"react-router": patch
4+
---
5+
6+
Export a separate `RouterProvider` from `react-router-dom` with `startViewTransition` support

.changeset/start-view-transition.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
---
22
"react-router-dom": minor
3-
"react-router": minor
43
"@remix-run/router": minor
54
---
65

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,16 +113,16 @@
113113
"none": "48.3 kB"
114114
},
115115
"packages/react-router/dist/react-router.production.min.js": {
116-
"none": "15.2 kB"
116+
"none": "13.9 kB"
117117
},
118118
"packages/react-router/dist/umd/react-router.production.min.js": {
119-
"none": "17.61 kB"
119+
"none": "16.3 kB"
120120
},
121121
"packages/react-router-dom/dist/react-router-dom.production.min.js": {
122-
"none": "13.61 kB"
122+
"none": "15.9 kB"
123123
},
124124
"packages/react-router-dom/dist/umd/react-router-dom.production.min.js": {
125-
"none": "19.91 kB"
125+
"none": "22.1 kB"
126126
}
127127
}
128128
}

packages/react-router-dom/__tests__/exports-test.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,23 @@ let nonReExportedKeys = new Set([
66
"UNSAFE_useRoutesImpl",
77
]);
88

9+
let modifiedExports = new Set(["RouterProvider"]);
10+
911
describe("react-router-dom", () => {
1012
for (let key in ReactRouter) {
11-
if (!nonReExportedKeys.has(key)) {
12-
it(`re-exports ${key} from react-router`, () => {
13-
expect(ReactRouterDOM[key]).toBe(ReactRouter[key]);
14-
});
15-
} else {
13+
if (nonReExportedKeys.has(key)) {
1614
it(`does not re-export ${key} from react-router`, () => {
1715
expect(ReactRouterDOM[key]).toBe(undefined);
1816
});
17+
} else if (modifiedExports.has(key)) {
18+
it(`re-exports a different version of ${key}`, () => {
19+
expect(ReactRouterDOM[key]).toBeDefined();
20+
expect(ReactRouterDOM[key]).not.toBe(ReactRouter[key]);
21+
});
22+
} else {
23+
it(`re-exports ${key} from react-router`, () => {
24+
expect(ReactRouterDOM[key]).toBe(ReactRouter[key]);
25+
});
1926
}
2027
}
2128
});

0 commit comments

Comments
 (0)