remove in-browser devtools, redux-thunk

Author: meesvandongen

examples/real-world/package-lock.json

@@ -4,9 +4,6 @@
   "private": true,
   "devDependencies": {
     "react-scripts": "^4.0.0",
-    "redux-devtools": "^3.7.0",
-    "redux-devtools-dock-monitor": "^1.2.0",
-    "redux-devtools-log-monitor": "^2.1.0",
     "redux-logger": "^3.0.6"
   },
   "dependencies": {
@@ -18,8 +15,7 @@
     "react-dom": "^17.0.1",
     "react-redux": "^7.2.1",
     "react-router-dom": "^5.2.0",
-    "redux": "^4.0.5",
-    "redux-thunk": "^2.3.0"
+    "redux": "^4.0.5"
   },
   "scripts": {
     "start": "react-scripts start",

examples/real-world/package.json

@@ -15,9 +15,9 @@ export const loadUser = createAsyncThunk(
     }
   },
   {
-    // If the user is already cached, this thunk will not dispatch anything.
     condition: ({ login, requiredFields }, { getState }) => {
       const user = getState().entities.users[login]
+      // If the user is already cached, nothing will be requested or dispatched
       const shouldProceed = !(
         user && requiredFields.every(key => user.hasOwnProperty(key))
       )
@@ -40,9 +40,9 @@ export const loadRepo = createAsyncThunk(
     }
   },
   {
-    // If the user is repo cached, this thunk will not dispatch anything.
     condition: ({ fullName, requiredFields }, { getState }) => {
       const repo = getState().entities.repos[fullName]
+      // If the repo is cached, nothing will be requested or dispatched
       const shouldProceed = !(
         repo && requiredFields.every(key => repo.hasOwnProperty(key))
       )
@@ -51,8 +51,9 @@ export const loadRepo = createAsyncThunk(
   }
 )
 
-// Fetches a page of starred repos by a particular user.
-// Bails out if page is cached and user didn't specifically request next page.
+/**
+ * Fetches a page of starred repos by a particular user.
+ */
 export const loadStarred = createAsyncThunk(
   'loadStarred',
   async ({ login }, { rejectWithValue, getState }) => {
@@ -66,9 +67,9 @@ export const loadStarred = createAsyncThunk(
     }
   },
   {
-    // If the user is repo cached, this thunk will not dispatch anything.
     condition: ({ login, nextPage }, { getState }) => {
       const { pageCount = 0 } = getState().pagination.starredByUser[login] || {}
+      // Bails out if page is cached and user didn't specifically request next page.
       const shouldProceed = !(pageCount > 0 && !nextPage)
       return shouldProceed
     }
@@ -77,8 +78,6 @@ export const loadStarred = createAsyncThunk(
 
 /**
  * Fetches a page of stargazers for a particular repo.
- * Bails out if page is cached and user didn't specifically request next page.
- * Relies on Redux Thunk middleware.
  */
 export const loadStargazers = createAsyncThunk(
   'loadStargazers',
@@ -93,10 +92,10 @@ export const loadStargazers = createAsyncThunk(
     }
   },
   {
-    // If the user is repo cached, this thunk will not dispatch anything.
     condition: ({ nextPage, fullName }, { getState }) => {
       const { pageCount = 0 } =
         getState().pagination.stargazersByRepo[fullName] || {}
+      // Bails out if page is cached and user didn't specifically request next page.
       const shouldProceed = !(pageCount > 0 && !nextPage)
       return shouldProceed
     }

examples/real-world/src/actions/index.js

@@ -13,8 +13,8 @@ const Explore = ({ onChange, value }) => {
     onChange(inputRef.current.value)
   }
 
-  const handleKeyUp = e => {
-    if (e.keyCode === 13) {
+  const handleKeyPress = e => {
+    if (e.key === 'Enter') {
       handleGoClick()
     }
   }
@@ -26,7 +26,7 @@ const Explore = ({ onChange, value }) => {
         size="45"
         ref={inputRef}
         defaultValue={value}
-        onKeyUp={handleKeyUp}
+        onKeyUp={handleKeyPress}
       />
       <button onClick={handleGoClick}>Go!</button>
       <p>