undid changes in createSlice

Author: Dudeonyx

src/createSlice.test.ts

@@ -69,7 +69,7 @@ describe('createSlice', () => {
 
     it('should have the correct action for increment', () => {
       expect(actions.increment()).toEqual({
-        type: 'increment',
+        type: 'cool/increment',
         payload: undefined
       })
     })
@@ -113,7 +113,9 @@ describe('createSlice', () => {
     const { reducer } = createSlice({
       reducers: {
         increment: state => state + 1,
-        multiply: (state, action) => state * action.payload,
+        multiply: (state, action) => state * action.payload
+      },
+      extraReducers: {
         [addMore.type]: (state, action) => state + action.payload.amount
       },
       initialState: 0

src/createSlice.ts

@@ -39,7 +39,8 @@ export interface Slice<
 export interface CreateSliceOptions<
   S = any,
   A extends Action = AnyAction,
-  CR extends CaseReducersMapObject<S, A> = CaseReducersMapObject<S, A>
+  CR extends CaseReducersMapObject<S, A> = CaseReducersMapObject<S, A>,
+  CR2 extends CaseReducersMapObject<S, A> = CaseReducersMapObject<S, A>
 > {
   /**
    * The slice's name. Used to namespace the generated action types and to
@@ -58,6 +59,17 @@ export interface CreateSliceOptions<
    * generated using `createAction()`.
    */
   reducers: CR
+
+  /**
+   * A mapping from action types to action-type-specific *case reducer*
+   * functions. These reducers should have existing action types used
+   * as the keys, and action creators will _not_ be generated.
+   */
+  extraReducers?: CR2
+}
+
+function getType(slice: string, actionKey: string): string {
+  return slice ? `${slice}/${actionKey}` : actionKey
 }
 
 /**
@@ -77,13 +89,20 @@ export function createSlice<
 ): Slice<S, A, Extract<keyof CR, string>> {
   const { slice = '', initialState } = options
   const reducers = options.reducers || {}
+  const extraReducers = options.extraReducers || {}
   const actionKeys = Object.keys(reducers)
 
-  const reducer = createReducer(initialState, reducers)
+  const reducerMap = actionKeys.reduce((map, actionKey) => {
+    map[getType(slice, actionKey)] = reducers[actionKey]
+    return map
+  }, extraReducers)
+
+  const reducer = createReducer(initialState, reducerMap)
 
   const actionMap = actionKeys.reduce(
     (map, action) => {
-      map[action] = createAction(action)
+      const type = getType(slice, action)
+      map[action] = createAction(type)
       return map
     },
     {} as any

type-tests/files/createSlice.typetest.ts

@@ -14,8 +14,10 @@ import {
     initialState: 0,
     reducers: {
       increment: (state: number, action) => state + action.payload,
-      decrement: (state: number, action) => state - action.payload,
-      "OTHER_ACTION_TYPE": (state: number, action) => state + action.payload.count
+      decrement: (state: number, action) => state - action.payload
+    },
+    extraReducers: {
+      "OTHER_ACTION_TYPE" : (state : number, action ) => state + action.payload.count
     }
   })