Skip to content

Commit dccf87c

Browse files
authored
Merge pull request #461 from reactjs/dryer-lint
Remove eslint-config-rackt
2 parents b6e3684 + 464a2cf commit dccf87c

File tree

4 files changed

+28
-9
lines changed

4 files changed

+28
-9
lines changed

.eslintrc

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
11
{
2-
"extends": "eslint-config-rackt",
2+
"parser": "babel-eslint",
3+
"extends": [
4+
"eslint:recommended",
5+
"plugin:import/errors",
6+
"plugin:react/recommended"
7+
],
8+
"parserOptions": {
9+
"ecmaVersion": 6,
10+
"sourceType": "module",
11+
"ecmaFeatures": {
12+
"jsx": true,
13+
"experimentalObjectRestSpread": true
14+
},
15+
},
316
"env": {
417
"browser": true,
518
"mocha": true,
@@ -9,9 +22,10 @@
922
"valid-jsdoc": 2,
1023
"react/jsx-uses-react": 1,
1124
"react/jsx-no-undef": 2,
12-
"react/wrap-multilines": 2
25+
"react/jsx-wrap-multilines": 2
1326
},
1427
"plugins": [
28+
"import",
1529
"react"
1630
]
1731
}

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"devDependencies": {
4545
"babel-cli": "^6.3.17",
4646
"babel-core": "^6.3.26",
47-
"babel-eslint": "^5.0.0-beta9",
47+
"babel-eslint": "^6.1.2",
4848
"babel-loader": "^6.2.0",
4949
"babel-plugin-check-es2015-constants": "^6.3.13",
5050
"babel-plugin-syntax-jsx": "^6.3.13",
@@ -72,9 +72,9 @@
7272
"babel-register": "^6.3.13",
7373
"cross-env": "^1.0.7",
7474
"es3ify": "^0.2.0",
75-
"eslint": "^1.7.1",
76-
"eslint-config-rackt": "1.1.0",
77-
"eslint-plugin-react": "^3.6.3",
75+
"eslint": "^3.3.1",
76+
"eslint-plugin-import": "^1.13.0",
77+
"eslint-plugin-react": "^6.1.1",
7878
"expect": "^1.8.0",
7979
"glob": "^6.0.4",
8080
"isparta": "4.0.0",

test/components/Provider.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/*eslint-disable react/prop-types*/
2+
13
import expect from 'expect'
24
import React, { PropTypes, Component } from 'react'
35
import TestUtils from 'react-addons-test-utils'

test/components/connect.spec.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/*eslint-disable react/prop-types*/
2+
13
import expect from 'expect'
24
import React, { createClass, Children, PropTypes, Component } from 'react'
35
import ReactDOM from 'react-dom'
@@ -351,9 +353,10 @@ describe('React', () => {
351353

352354
componentDidMount() {
353355
// Simulate deep object mutation
354-
this.state.bar.baz = 'through'
356+
const bar = this.state.bar
357+
bar.baz = 'through'
355358
this.setState({
356-
bar: this.state.bar
359+
bar
357360
})
358361
}
359362

@@ -1022,7 +1025,7 @@ describe('React', () => {
10221025
/You must pass a component to the function/
10231026
)
10241027
})
1025-
1028+
10261029
it('should throw an error if mapState, mapDispatch, or mergeProps returns anything but a plain object', () => {
10271030
const store = createStore(() => ({}))
10281031

0 commit comments

Comments
 (0)