refactor get modules

Author: tylerhutcherson

redisvl/index/index.py

@@ -27,7 +27,6 @@
 from redisvl.redis.connection import (
     RedisConnectionFactory,
     convert_index_info_to_schema,
-    unpack_redis_modules,
     validate_modules,
 )
 from redisvl.redis.utils import convert_bytes
@@ -340,9 +339,7 @@ def from_existing(
             )
 
         # Validate modules
-        installed_modules = unpack_redis_modules(
-            convert_bytes(redis_client.module_list())
-        )
+        installed_modules = RedisConnectionFactory._get_modules(redis_client)
         validate_modules(installed_modules, [{"name": "search", "ver": 20810}])
 
         # Fetch index info and convert to schema
@@ -757,9 +754,7 @@ async def from_existing(
             )
 
         # Validate modules
-        installed_modules = unpack_redis_modules(
-            convert_bytes(await redis_client.module_list())
-        )
+        installed_modules = await RedisConnectionFactory._get_modules_async(redis_client)
         validate_modules(installed_modules, [{"name": "search", "ver": 20810}])
 
         # Fetch index info and convert to schema

redisvl/redis/connection.py

@@ -233,6 +233,18 @@ def validate_redis(
                 client, lib_name, required_modules
             )
 
+    @staticmethod
+    def _get_modules(client: Redis) -> Dict[str, Any]:
+        return unpack_redis_modules(
+            convert_bytes(client.module_list())
+        )
+
+    @staticmethod
+    async def _get_modules_async(client: AsyncRedis) -> Dict[str, Any]:
+        return unpack_redis_modules(
+            convert_bytes(await client.module_list())
+        )
+
     @staticmethod
     def _validate_sync_redis(
         client: Redis,
@@ -249,7 +261,7 @@ def _validate_sync_redis(
             client.echo(_lib_name)
 
         # Get list of modules
-        installed_modules = unpack_redis_modules(convert_bytes(client.module_list()))
+        installed_modules = RedisConnectionFactory._get_modules(client)
 
         # Validate available modules
         validate_modules(installed_modules, required_modules)
@@ -270,9 +282,7 @@ async def _validate_async_redis(
             await client.echo(_lib_name)
 
         # Get list of modules
-        installed_modules = unpack_redis_modules(
-            convert_bytes(await client.module_list())
-        )
+        installed_modules = await RedisConnectionFactory._get_modules_async(client)
 
         # Validate available modules
         validate_modules(installed_modules, required_modules)

tests/integration/test_search_index.py

@@ -68,6 +68,8 @@ def test_search_index_from_existing(client, index):
 
 
 def test_search_index_from_existing_complex(client):
+    if not compare_versions(redis_version, "7.2.0"):
+        pytest.skip("Not using a late enough version of Redis")
     schema = {
         "index": {
             "name": "test",