async_cluster: properly remove old nodes

Author: utkarshgupta137

redis/asyncio/cluster.py

@@ -746,7 +746,7 @@ def __init__(
         host: str,
         port: int,
         server_type: Optional[str] = None,
-        max_connections: int = 2 ** 31,
+        max_connections: int = 2**31,
         connection_class: Type[Connection] = Connection,
         **connection_kwargs: Any,
     ) -> None:
@@ -902,18 +902,16 @@ def set_nodes(
         new: Dict[str, "ClusterNode"],
         remove_old: bool = False,
     ) -> None:
-        tasks = []
         if remove_old:
-            tasks = [
-                asyncio.ensure_future(node.disconnect())
-                for name, node in old.items()
-                if name not in new
-            ]
+            for name in list(old.keys()):
+                if name not in new:
+                    asyncio.ensure_future(old.pop(name).disconnect())
+
         for name, node in new.items():
             if name in old:
                 if old[name] is node:
                     continue
-                tasks.append(asyncio.ensure_future(old[name].disconnect()))
+                asyncio.ensure_future(old[name].disconnect())
             old[name] = node
 
     def _update_moved_slots(self) -> None: