Skip to content

Commit 940d9fc

Browse files
authored
Removing lots-of-pythons container (#1827)
1 parent 989d06d commit 940d9fc

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Here's how to get started with your code contribution:
3232

3333
1. Create your own fork of redis-py
3434
2. Do the changes in your fork
35-
3.
35+
3.
3636
*Create a virtualenv and install the development dependencies from the dev_requirements.txt file:*
3737

3838
a. python -m venv .venv
@@ -69,12 +69,12 @@ configuration](https://redis.io/topics/sentinel).
6969

7070
## Testing
7171

72-
Call `invoke tests` to run all tests, or `invoke all-tests` to run linters
73-
tests as well. With the 'tests' and 'all-tests' targets, all Redis and
74-
RedisCluster tests will be run.
72+
Call `invoke tests` to run all tests, or `invoke all-tests` to run linters
73+
tests as well. With the 'tests' and 'all-tests' targets, all Redis and
74+
RedisCluster tests will be run.
7575

76-
It is possible to run only Redis client tests (with cluster mode disabled) by
77-
using `invoke standalone-tests`; similarly, RedisCluster tests can be run by using
76+
It is possible to run only Redis client tests (with cluster mode disabled) by
77+
using `invoke standalone-tests`; similarly, RedisCluster tests can be run by using
7878
`invoke cluster-tests`.
7979

8080
Each run of tox starts and stops the various dockers required. Sometimes
@@ -85,9 +85,7 @@ tests against multiple versions of python. Feel free to test your
8585
changes against all the python versions supported, as declared by the
8686
tox.ini file (eg: tox -e py39). If you have the various python versions
8787
on your desktop, you can run *tox* by itself, to test all supported
88-
versions. Alternatively, as your source code is mounted in the
89-
**lots-of-pythons** docker, you can start exploring from there, with all
90-
supported python versions!
88+
versions.
9189

9290
### Docker Tips
9391

tox.ini

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,6 @@ ports =
7373
36379:6379/tcp
7474
healtcheck_cmd = python -c "import socket;print(True) if 0 == socket.socket(socket.AF_INET, socket.SOCK_STREAM).connect_ex(('127.0.0.1',36379)) else False"
7575

76-
[docker:lots-of-pythons]
77-
name = lots-of-pythons
78-
image = redisfab/lots-of-pythons:latest
79-
volumes =
80-
bind:rw:{toxinidir}:/data
81-
8276
[docker:redis_cluster]
8377
name = redis_cluster
8478
image = redisfab/redis-py-cluster:6.2.6-buster

0 commit comments

Comments
 (0)