Skip to content

Commit 2f2bc5d

Browse files
dvora-hvladvildanov
authored andcommitted
fix acl_genpass with bits (#3062)
1 parent f752591 commit 2f2bc5d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

redis/commands/core.py

+1
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ def acl_genpass(self, bits: Union[int, None] = None, **kwargs) -> ResponseT:
9797
b = int(bits)
9898
if b < 0 or b > 4096:
9999
raise ValueError
100+
pieces.append(b)
100101
except ValueError:
101102
raise DataError(
102103
"genpass optionally accepts a bits argument, between 0 and 4096."

tests/test_commands.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,9 @@ def test_acl_genpass(self, r):
201201
r.acl_genpass(-5)
202202
r.acl_genpass(5555)
203203

204-
r.acl_genpass(555)
204+
password = r.acl_genpass(555)
205205
assert isinstance(password, (str, bytes))
206+
assert len(password) == 139
206207

207208
@skip_if_server_version_lt("7.0.0")
208209
@skip_if_redis_enterprise()

0 commit comments

Comments
 (0)