Fix preload warning (#112)

* delete the stopped container by default at tear down

* fix test-time on 4 test-cases.

* removed the -n parameter, since it was incompatible with --test-time and was causing the benchmark to fail

* adding a test-time=180 to testcase memtier_benchmark-10Mkeys-load-hash-5-fields-with-100B-values-pipeline-10.yml

* Re-order --preserve_temporary_client_dirs --client_aggregated_results_folder so that we can create an aggregated folder and still delete the temp files after. In addition, delete temp JSON files created by redis-benchmark (and not by memtier-benchmark)

* change the auto-remove to True, so that we dont accumulate un-used containers

* Correctly label preload in log and do not issue warning is preload is less than 60 seconds

* remove warning when preload is less than 60 sec. Label as preload

Co-authored-by: root <[email protected]>
Co-authored-by: Martin Dimitrov <[email protected]>
Co-authored-by: filipe oliveira <[email protected]>

Author: 4 people

redis_benchmarks_specification/__runner__/runner.py

@@ -698,7 +698,7 @@ def data_prepopulation_step(
 
         preload_end_time = datetime.datetime.now()
         preload_duration_seconds = calculate_client_tool_duration_and_check(
-            preload_end_time, preload_start_time
+            preload_end_time, preload_start_time, "Preload", False
         )
         logging.info(
             "Tool {} seconds to load data. Output {}".format(

redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py

@@ -632,7 +632,7 @@ def process_self_contained_coordinator_stream(
                                         "mode": "rw",
                                     },
                                 },
-                                auto_remove=False,
+                                auto_remove=True,
                                 privileged=True,
                                 working_dir=benchmark_tool_workdir,
                                 command=benchmark_command_str,
@@ -902,7 +902,7 @@ def data_prepopulation_step(
 
         preload_end_time = datetime.datetime.now()
         preload_duration_seconds = calculate_client_tool_duration_and_check(
-            preload_end_time, preload_start_time
+            preload_end_time, preload_start_time, "Preload", False
         )
         logging.info(
             "Tool {} seconds to load data. Output {}".format(