Add new settings for clean ups #2768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
2144-cleanups
branch
5 times, most recently
from
3a73f6a to
f10cc71
Compare
rgrunber
reviewed
Nov 2, 2022
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Overall looks good to me. I think we just need to decide regarding the cleanups that can only be activated when their corresponding problem is set to error/warning.
datho7561
force-pushed
the
2144-cleanups
branch
from
f10cc71 to
7142cf5
Compare
rgrunber
reviewed
Nov 8, 2022
rgrunber
reviewed
Nov 8, 2022
datho7561
force-pushed
the
2144-cleanups
branch
from
7142cf5 to
f1fe31b
Compare
Member
|
In the README.md , there is an entry for "New in 1.13.0". Add this setting there. |
datho7561
force-pushed
the
2144-cleanups
branch
from
f1fe31b to
617faf1
Compare
rgrunber
reviewed
Nov 9, 2022
rgrunber
reviewed
Nov 9, 2022
rgrunber
reviewed
Nov 9, 2022
- Add documentation (accessible through a command) for what each clean up does Depends on eclipse-jdtls/eclipse.jdt.ls#2298 Closes redhat-developer#2144 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
2144-cleanups
branch
from
617faf1 to
6118a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on eclipse-jdtls/eclipse.jdt.ls#2298
Closes #2144
Signed-off-by: David Thompson [email protected]